Add location pointing to the end of a source #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianschanda
requested changes
Aug 23, 2023
markusrosskopf
changed the title
florianschanda
requested changes
Aug 24, 2023
trlc/lexer.py
Outdated
| def get_end_location(self): | ||
| """Get location pointing to the end of a source.""" | ||
|
|
||
| lines_in_between = self.lexer.content[self.start_pos : self.end_pos + 1].count("\n") |
There was a problem hiding this comment.
This line is too long, the pylint check is failing. You can run this locally with
make lint
trlc/lexer.py
Outdated
| lines_in_between = self.lexer.content[self.start_pos : self.end_pos + 1].count("\n") | ||
| end_line = self.line_no + lines_in_between | ||
| n = self.end_pos | ||
| while n > self.start_pos: |
There was a problem hiding this comment.
Not sure this logic fully works. For this input file:
'''foo
bar'''
We would get an end location of line 2, column 7, but column should be 6.
trlc/lexer.py
Outdated
| @@ -108,6 +108,20 @@ def context_lines(self): | |||
| return [stripped_line, | |||
| " " * stripped_offset + "^" * min(tlen, maxtrail)] | |||
|
|
|||
| def get_end_location(self): | |||
| """Get location pointing to the end of a source.""" | |||
There was a problem hiding this comment.
This docstring should go into the initial declaration of the function, in Location
florianschanda
requested changes
Aug 28, 2023
trlc/lexer.py
Outdated
| end_line = self.line_no + lines_in_between | ||
|
|
||
| end_col = self.end_pos + 1 | ||
| for n in range(self.end_pos, 0, -1): |
There was a problem hiding this comment.
That range is too big, you should stop where the token begins, not at 0.
florianschanda
merged commit 4d65cf1
into
bmw-software-engineering:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.