Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iteration api by section #90

Merged
merged 13 commits into from
Oct 14, 2024
Merged

Iteration api by section #90

merged 13 commits into from
Oct 14, 2024

Conversation

mugdhadhole1
Copy link
Contributor

#12

@mugdhadhole1 mugdhadhole1 requested a review from a team as a code owner June 12, 2024 14:19
christophkloeffel
christophkloeffel suggested changes Jun 12, 2024
View reviewed changes
trlc/ast.py Show resolved Hide resolved
trlc/parser.py Outdated Show resolved Hide resolved
trlc/parser.py Outdated Show resolved Hide resolved
trlc/ast.py Outdated Show resolved Hide resolved
trlc/ast.py Outdated Show resolved Hide resolved
christophkloeffel
christophkloeffel reviewed Jun 12, 2024
View reviewed changes
trlc/parser.py Outdated Show resolved Hide resolved
@florianschanda
Copy link
Collaborator

I think instead of just coding something it would be good to first define on #12 what this actually means. I can think of several interfaces:

  • a section iterator, which can then be iterated over again to get items
  • a modification of the normal iterator that yield sections along normal items; and you then have to recurse
  • a iteration via callback similar to http://www.saxproject.org/
  • ... something else?

@christophkloeffel christophkloeffel mentioned this pull request Jul 25, 2024
Closed
@mugdhadhole1
iteration api - by section #12
66f1170
@mugdhadhole1
Fetching sections and the record objects by section #12
c97dd1d
@mugdhadhole1
Fetching sections and the record objects by section #12 - removing un…
14d7e35 
…necessary files
@mugdhadhole1
Added section level information #12
3d4aae9
@mugdhadhole1
Corrections in the iteration api by section #12
1990661
@mugdhadhole1
Corrections for make lint cli error added #12
854d728
@mugdhadhole1
corrections for make lint cli error added #12
1f93d2a
@mugdhadhole1
Reduced lines of code in function parse_section_declaration in parser…
6325db6 
….py file
@mugdhadhole1
unit test for new iteration API by section
eaeb77d 
code cleaning in iter_record_objects_by_section function
GitHub issue - #12
@mugdhadhole1
Added the Iteration API by Section in toctree
c3fa429 
Created a section_api.rst file for documenting Iteration API by Section
Added a link for Iteration API by Section documentation
Added comments for iter_record_objects_by_section() function
@mugdhadhole1
Added comments for iter_record_objects_by_section() function
6864b11
This was linked to issues Sep 11, 2024
new iteration api: by file #11
Closed
new iteration api: by section #12
Closed
@christophkloeffel christophkloeffel enabled auto-merge (squash) October 14, 2024 16:37
@christophkloeffel christophkloeffel merged commit f4a647c into main Oct 14, 2024
21 checks passed
@christophkloeffel christophkloeffel deleted the iteration-api-by-section branch October 14, 2024 16:59
@phiwuu phiwuu added the topic: API Affects the user-facing API label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianschanda florianschanda florianschanda left review comments

@christophkloeffel christophkloeffel christophkloeffel approved these changes

@ankushsonare1 ankushsonare1 Awaiting requested review from ankushsonare1

@akashsurwase1 akashsurwase1 Awaiting requested review from akashsurwase1

Assignees
No one assigned
Labels
topic: API Affects the user-facing API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new iteration api: by section new iteration api: by file
4 participants
@mugdhadhole1 @florianschanda @christophkloeffel @phiwuu