Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correct no-exceptions removal for cc_opts and opts #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GWRon
Copy link
Contributor

@GWRon GWRon commented Feb 8, 2025

"print" is incorrect but not caught as error messages in the bmk files are ignored there.
Also the "opts" replaced stuff in "cc_opts" incorrectly.

While ":find()" can return Null, ":gsub" simply returns self even if nothing was changed

"print" is incorrect but not caught as error messages in the bmk files
are ignored there.
Also the "opts" replaced stuff in "cc_opts" incorrectly.

While ":find()" can return Null, ":gsub" simply returns self even if
nothing was changed
@GWRon
Copy link
Contributor Author

GWRon commented Feb 8, 2025

Attention: This is variant2, there is variant1 too: #138

It depends on what you want:
variant1 assumes that fno-exception is just to remove from cc_opts.
variant2 assumes that fno-exceptions should be removed from cc_opts AND opts.

@GWRon
Copy link
Contributor Author

GWRon commented Feb 8, 2025

PS:
https://blitzmax.org/docs/en/language/pre_post_compilation_scripts/

SuperStrict

' @bmk echo *** Building my cool app ***
' @bmk include "my_own_scripts.bmk"
'
' @bmk push cc_opts
' @bmk addccopt -DSPECIAL_OPTION
'
' @bmk make "src/someglue.cpp"
'
' @bmk pop cc_opts
' @bmk make "src/other.cpp"
'

The example is incorrect ...when adding/setting opts you now need a "key" (some name so you can override later)

The example itself won't compile because of
bmx-ng/bcc#656
(I simply added "newlines" between the commands to work around)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant