Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Token transfer parameter validation #185

Merged
merged 58 commits into from
Dec 12, 2024
Merged

Conversation

Halibao-Lala
Copy link
Collaborator

@Halibao-Lala Halibao-Lala commented Dec 12, 2024

Description

Issue ticket number and link

Types of changes

  • Docs refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated changeset
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Halibao-Lala Halibao-Lala changed the title Feat/address check feat: Token transfer parameter validation Dec 12, 2024
@@ -212,7 +250,30 @@ export function TransferButton({
} else if (transferActionInfo.bridgeType === 'deBridge') {
try {
let deBridgeHash: string | undefined;

const isValidToken = await await bridgeSDK.deBridge.validateDeBridgeToken({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is two await correct?

@Halibao-Lala Halibao-Lala merged commit 3ea5dc5 into main Dec 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants