-
Notifications
You must be signed in to change notification settings - Fork 48
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'develop' into krish/p2p_sync
- Loading branch information
Showing
20 changed files
with
2,095 additions
and
142 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,19 @@ | ||
--- | ||
name: Report a bug | ||
about: Something with go-ethereum is not working as expected | ||
about: Something with opBNB is not working as expected | ||
title: '' | ||
labels: 'type:bug' | ||
assignees: '' | ||
--- | ||
|
||
#### System information | ||
|
||
Geth version: `geth version` | ||
CL client & version: e.g. lighthouse/nimbus/[email protected] | ||
Network: `mainnet`/`testnet`/`local` | ||
|
||
if you are running a local node, please provide the following information: | ||
op-node version: `op-node version` | ||
op-geth version: `op-geth -v` | ||
OS & Version: Windows/Linux/OSX | ||
Commit hash : (if `develop`) | ||
|
||
#### Expected behaviour | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
### Description | ||
|
||
add a description of your changes here... | ||
|
||
### Rationale | ||
|
||
tell us why we need these changes... | ||
|
||
### Example | ||
|
||
add an example CLI or API response... | ||
|
||
### Changes | ||
|
||
Notable changes: | ||
* add each change in a bullet point here | ||
* ... |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
name: Unit Test | ||
|
||
on: | ||
pull_request: | ||
types: [ opened, synchronize, reopened ] | ||
push: | ||
branches: [main, develop] | ||
|
||
jobs: | ||
unit_test: | ||
name: unit_test | ||
runs-on: ubuntu-22.04 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-go@v4 | ||
with: | ||
go-version: '^1.21.3' | ||
- run: make test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2103,6 +2103,13 @@ func TestGolangBindings(t *testing.T) { | |
if out, err := replacer.CombinedOutput(); err != nil { | ||
t.Fatalf("failed to replace binding test dependency to current source tree: %v\n%s", err, out) | ||
} | ||
|
||
replacer = exec.Command(gocmd, "mod", "edit", "-x", "-require", "github.com/cometbft/[email protected]", "-replace", "github.com/cometbft/cometbft=github.com/bnb-chain/[email protected]") // Repo root | ||
replacer.Dir = pkg | ||
if out, err := replacer.CombinedOutput(); err != nil { | ||
t.Fatalf("failed to replace cometbft dependency to bnb-chain source: %v\n%s", err, out) | ||
} | ||
|
||
tidier := exec.Command(gocmd, "mod", "tidy") | ||
tidier.Dir = pkg | ||
if out, err := tidier.CombinedOutput(); err != nil { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.