contracts: update based on audit review suggestions #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendanzhentan
force-pushed
the
develop
branch
2 times, most recently
from
36c2a78 to
e31ae56
Compare
owen-reorg
reviewed
Dec 6, 2023
Co-authored-by: Owen <[email protected]>
bendanzhentan
force-pushed
the
develop
branch
from
e31ae56 to
5908c6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates:
contracts: limit range of _delegationFee for setDelegationFee
In order to avoid mis-configuring
setDelegationFee, we add a guard for lower and upper limit fordelegationFeecontracts: remove useless
receive()andfallback()contracts: replace transferFrom to SafeERC20.safeTransferFrom
SafeERC20.safeTransferFrom helps maintain full compliance with the ERC20 standard, which not all tokens may adhere to completely.