feat: enable prefetch on the new engine #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keefel
force-pushed
the
enhance-prefetch2
branch
from
fe51c20 to
331b982
Compare
keefel
force-pushed
the
enhance-prefetch2
branch
from
331b982 to
e97fdd0
Compare
keefel
force-pushed
the
enhance-prefetch2
branch
from
e97fdd0 to
3dfa737
Compare
j75689
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable trie prefetch on the new engine and implement some optimizations.
Rationale
There are two optimizations:
Previously, the prefetch feature did not affect the old engine using parallel state root computation. We should prefetch the account tree and storage trees concurrently to ensure that the account tree nodes are loaded before computing the state root. This optimization can reduce the state root computation time of the old engine by about 28%.
Enable prefetching on the new engine, this optimization can reduce the state root computation time of the new engine by about 20%.
Example
NA
Changes
Notable changes:
Potential Impacts