Merge pull request #109 from HAOYUatHZ/patch-2

style: refactor to more consistent error handlings style
bnb-chain · Jan 10, 2024 · c76a1a5 · c76a1a5
2 parents 409542e + b15a0cf
commit c76a1a5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/ecdsa/keygen/round_3.go b/ecdsa/keygen/round_3.go
@@ -147,10 +147,9 @@ func (round *round3) Start() *tss.Error {
 		var multiErr error
 		if len(culprits) > 0 {
 			for _, vssResult := range vssResults {
-				if vssResult.unWrappedErr == nil {
-					continue
+				if vssResult.unWrappedErr != nil {
+					multiErr = multierror.Append(multiErr, vssResult.unWrappedErr)
 				}
-				multiErr = multierror.Append(multiErr, vssResult.unWrappedErr)
 			}
 			return round.WrapError(multiErr, culprits...)
 		}

diff --git a/eddsa/keygen/round_3.go b/eddsa/keygen/round_3.go
@@ -131,10 +131,9 @@ func (round *round3) Start() *tss.Error {
 		var multiErr error
 		if len(culprits) > 0 {
 			for _, vssResult := range vssResults {
-				if vssResult.unWrappedErr == nil {
-					continue
+				if vssResult.unWrappedErr != nil {
+					multiErr = multierror.Append(multiErr, vssResult.unWrappedErr)
 				}
-				multiErr = multierror.Append(multiErr, vssResult.unWrappedErr)
 			}
 			return round.WrapError(multiErr, culprits...)
 		}