Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and show repo tags in the UI #6170

Merged
merged 6 commits into from
Jul 1, 2024

Conversation

chrisrueger
Copy link
Contributor

@chrisrueger chrisrueger commented Jun 30, 2024

In this PR

  • add documentation to the manual about our repository tags and how they affect resolution introduced in Add support for repository tags #6116 (-runrepos)
  • show tags in repo browser as comma separated list
image

@chrisrueger chrisrueger marked this pull request as ready for review June 30, 2024 19:48
Signed-off-by: Christoph Rueger <[email protected]>
@chrisrueger
Copy link
Contributor Author

@juergen-albert since you brought up the usecase of excluding the baseline repo, maybe you could do a quick review of the docs
@pkriens thoughts?

@juergen-albert
Copy link
Contributor

The documentation looks solid. Digging into this again, I have one remark and one possible change request.

Remark: We should not use <<EMTPY>> as this would indicate to me, that the Repository is empty. I'm not sure what we should write. Ideally something that indicates that indicates that it is used for resolve by default. Not sure how this could look. An alternative could also be <<NO TAGS>>.

Possible change request or something for an additional issue: It would be nice to have something like -runrepos, where we can define the tags I want to use. For a test e.g. I can then use -runrepostags: resolve, test (even though the instruction looks rather awkward.

@chrisrueger
Copy link
Contributor Author

chrisrueger commented Jul 1, 2024

Remark: We should not use <<EMTPY>> as this would indicate to me, that the Repository is empty. I'm not sure what we should write. Ideally something that indicates that indicates that it is used for resolve by default. Not sure how this could look. An alternative could also be <<NO TAGS>>.

Thanks @juergen-albert . The empty was a suggestion by @pkriens when we had a call about it. <<EMPTY>> is just a placeholder which could have been "foobar" as well. It just means "something else than 'resolve'".

My suggestion: for the sake of this current PR we keep <<EMPTY>> and I will create a new Issue / PR for the change and also update the docs afterwards. Until 7.1. is still in the making I think we are still ok to do such change. I think your suggestion <<NO TAGS>> works too, but since it is highly subjective and I suggest a separate issue. I have a no real preference.

Possible change request or something for an additional issue: It would be nice to have something like -runrepos, where we can define the tags I want to use. For a test e.g. I can then use -runrepostags: resolve, test (even though the instruction looks rather awkward.

Same here. I would suggest creating a new issue. I had something like this in the beginning but removed it during the discussion about the first version of this feature. Basically what I added was that you could specify a tag in -runrepos like this: -runrepos: @resolve, @test, @myothertag
I think in a new issue we can still discuss the details.

@juergen-albert
Copy link
Contributor

Okay. Then +1 from me!

@juergen-albert
Copy link
Contributor

juergen-albert commented Jul 1, 2024

And thanks heaps again. This feature is highly appreciated.

@juergen-albert juergen-albert merged commit 43faf74 into bndtools:master Jul 1, 2024
10 checks passed
@chrisrueger
Copy link
Contributor Author

Thanks for merging @juergen-albert 👍

@chrisrueger
Copy link
Contributor Author

added the link to the docu to the 7.1.0 release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants