Adds a run system command in a path macro and fixes existing docu #6250
Conversation
Signed-off-by: Juergen Albert <[email protected]>
juergen-albert
force-pushed
the
system_in_path
branch
from
36e63cd
to
b29830c
Compare
There was a problem hiding this comment.
I don't see this as a good idea. Sure it is no worse security wise than system, but will lead to non-portable builds. As soon as you start cd'ing to other random folders it assume things outside the Bnd workspace and that is probably non-portable and will lead to builds which work for those who have the proper folders in place but not everyone else.
| } | ||
|
|
||
| # Extracts the current git SHA for the Project and enters the password as input | ||
| Git-SHA: ${system;git rev-list -1 --no-abbrev-commit HEAD;mypassword} |
There was a problem hiding this comment.
I don't think this is a helpful example since the command does not care about stdin :-)
|
|
||
| public String system(boolean allowFail, String runDirectory, String command, String input) | ||
| throws IOException, InterruptedException, InterruptedException { | ||
| return system(allowFail, new File(runDirectory), command, input); |
There was a problem hiding this comment.
Should this be IO.getFile(runDirectory) since that will handle some interesting cases like ~ expansion?
| @DisabledOnOs({ | ||
| OS.MAC, OS.LINUX | ||
| }) |
There was a problem hiding this comment.
| @DisabledOnOs({ | |
| OS.MAC, OS.LINUX | |
| }) | |
| @EnabledOnOs(OS.Windows) |
|
|
||
| if (args.length > 2) { | ||
| input = args[2]; | ||
| if (extractPath) { |
There was a problem hiding this comment.
This whole section looks overly complex and ripe for errors.
| public void testSystemInPath() throws Exception { | ||
| try (Processor p = new Processor()) { | ||
| Macro macro = new Macro(p); | ||
| assertEquals("/tmp", macro.process("${system-in-path;/tmp;pwd}")); |
There was a problem hiding this comment.
Instead of a hard coded path, you should create a folder in the @InjectTemporaryDirectory temp folder. Then these test can run on all OS.
| --- | ||
| layout: default | ||
| class: Macro | ||
| title: system-in-path ';' PATH ';' CMD ( ';' INPUT )? |
There was a problem hiding this comment.
The macro names are not awesome. Naming is hard :-)
|
@juergen-albert Ok to close this? I think it is a security issue and it nibbles at the core concept of the atomic workspace? |
Signed-off-by: Juergen Albert [email protected]