-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for Java 24 Build #6371
base: master
Are you sure you want to change the base?
Conversation
hope to fix a Java 24 build problem Signed-off-by: Christoph Rueger <[email protected]>
Sure, I give a try locally and get back to you. |
b9f2512
to
e8e6cb1
Compare
I have reverted the change to the github actions for Java 24. Upgrading whole gradle build to Java 24 seems to be a separate larger task. But Java 23 build already passed. Let's see if this PR fixes @scordio problem and wait for him to confirm. |
I'm struggling to reproduce the issue locally (on MacOS Sonoma 14.5), using OpenJDK 24 (macOS / AArch64). Instead of the error I reported, I get the following:
Does anyone see what the difference might be? |
Is there a Version of package or Projekt we should increse? |
You look to be further through the process. This next error appears to be Eclipse Equinox not knowing what Java 24 is. This is another library that will need to be updated to support Java 24. |
What I couldn't figure out is what made my local environment to be further through the process, as I'm still using bnd 7.0.0. Right now, I only have my Mac vs. GitHub Actions to compare. In case someone also wants to try out assertj-core-osgi with the changes from this branch, please remember to revert assertj/assertj@f4c6ea0. |
Related to #6370
hope to fix a Java 24 build problem
@pkriens is this something which should still go to 7.1.0 ?
And also: I added Java 23 temporarily to the build (Java 24 was not available in the Github actions... probably because it is still early access @timothyjward ). But maybe we already see something with JDK23.
@scordio Are you able to test this fix in your build with Java 24 to see if it fixes your problem?