Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a New Language #270

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added a New Language #270

wants to merge 3 commits into from

Conversation

NZehnder
Copy link

Addedd a Sub Type of German to Project.
Called Swiss German, if welcomed, feel Free to Add it to the Project.

Added Swiss German to the Translations JavaScript-File
Removed custom Translations-Strings of my own Version.
@@ -473,6 +473,40 @@ export const Translations = [
select: 'Sprache auswählen',
},
},
{
id: 'de-CH',
name: 'Schweizer Deutsch',
Copy link
Contributor

@WebSnke WebSnke Jan 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: 'Schweizer Deutsch',
name: 'German - Schwizerdütsch',

I suggest changing it to "German - Schwizerdütsch" instead so that it appears next to "German - Hochdeutsch", just like with the names for the Portugese translations.

@WebSnke
Copy link
Contributor

WebSnke commented Jan 3, 2024

You should also use a more fitting name for this pull request.

@bndw
Copy link
Owner

bndw commented Feb 13, 2024

@NZehnder This PR needs a couple small updates to be merged:

  • Please update the language name as per the suggestion by @WebSnke
  • Please run make fmt.write to auto-format the code so the build check passes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants