Support Pydantic v1 output #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-krechan
approved these changes
Nov 10, 2023
| @@ -37,13 +37,21 @@ def generate_bo4e_schemas(input_directory: Path, output_directory: Path): | |||
| help="Output directory for the generated python files.", | |||
| required=True, | |||
| ) | |||
| @click.option( | |||
| "--pydantic-v1/--pydantic-v2", | |||
There was a problem hiding this comment.
wie gibt man das nun an?
kann man entweder --pydantic-v1 oder -pydantic-v2 angeben?
There was a problem hiding this comment.
Genau. Und der default ist v2
src/bo4e_generator/__main__.py
Outdated
| @@ -37,13 +37,21 @@ def generate_bo4e_schemas(input_directory: Path, output_directory: Path): | |||
| help="Output directory for the generated python files.", | |||
| required=True, | |||
| ) | |||
| @click.option( | |||
| "--pydantic-v1/--pydantic-v2", | |||
| "-p", | |||
There was a problem hiding this comment.
und wie würde man in der abgekürzten Form angeben?
-p 1 vs -p 2 oder -p v1 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DeltaDaniel might need this to work together with https://github.com/Hochfrequenz/bo4e-python-orm