Add Zeitmenge and Zeitspanne (as future replacements for Zeitraum) #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lord-haffi
reviewed
Oct 6, 2023
src/bo4e/com/zeitmenge.py
Outdated
Comment on lines
10
to
19
| class Zeitmenge(COM): | ||
| """ | ||
| Eine Zeitmenge ist eine Anzahl mit Zeiteinheit; z.B. "5 Tage" oder "1 Monat". | ||
| Der Unterschied zur Zeitspanne ist, dass Start- und Endzeitpunkt nicht angegeben werden. | ||
| Die Zeitmenge ist aus dem COM Zeitraum hervorgegangen, das in Zeitspanne und Zeitmenge aufgeteilt wurde. | ||
| """ | ||
|
|
||
| # I made those _not_ optional because the entire instance of Zeitmenge is pointless if one of the two is missing | ||
| einheit: Zeiteinheit #: z.B. Tage | ||
| dauer: Decimal #: z.B: 5 |
There was a problem hiding this comment.
Das soll doch mit dem COM Menge verheiratet werden. Planst du, das hier einzuführen, um es später wieder rauszukicken?
There was a problem hiding this comment.
dfer PR ist von gestern.
lord-haffi
reviewed
Oct 6, 2023
src/bo4e/com/zeitspanne.py
Outdated
| """ | ||
|
|
||
| # I made those _not_ optional because the entire instance of Zeitmenge is pointless if one of the two is missing | ||
| start: Optional[datetime] #: inklusiver Beginn |
There was a problem hiding this comment.
In Pydantic v2 musst du explizit den default-Wert None mitgeben, wenn du das Feld auch weglassen können willst.
|
Hi @DeltaDaniel ich habe gesehen, du hast das schon in #625 genutzt. Sollen wir vllt erst den hier durchbringen? ich komm heute nicht mehr dazu, den mit den Absprachen von heute zu updaten. |
hf-fvesely
reviewed
Oct 23, 2023
hf-fvesely
reviewed
Oct 23, 2023
hf-fvesely
approved these changes
Oct 23, 2023
|
This branch was merged into the branch in this PR: #625, has been updated in parts and is now on main. So this PR has become obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.