-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Zeitraum to Zeitspanne, fix tests, change zeitspanne datetime to date and time #745
Open
hf-lkosareva
wants to merge
15
commits into
main
Choose a base branch
from
714-change-zeitraum-to-zeitspanne
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3d2cfe9
Change Zeitraum to Zeitspanne, fix tests
hf-lkosareva a3dac32
Update src/bo4e/com/vertragskonditionen.py
hf-lkosareva 8804f9c
Update CONTRIBUTING.md
hf-lkosareva 1bc6475
Update src/bo4e/com/ausschreibungsdetail.py
hf-lkosareva 636322d
Update src/bo4e/com/regionaleraufabschlag.py
hf-lkosareva 8e7ee43
Update src/bo4e/com/verbrauch.py
hf-lkosareva 187ac00
Update src/bo4e/com/verbrauch.py
hf-lkosareva ea5f26f
Update src/bo4e/com/zaehlwerk.py
hf-lkosareva 211db11
Merge branch 'main' into 714-change-zeitraum-to-zeitspanne
hf-lkosareva 25c744d
fix linting and test
hf-lkosareva 0718ec8
Merge branch 'main' into 714-change-zeitraum-to-zeitspanne
hf-fvesely a7ec26d
Merge remote-tracking branch 'origin/main' into 714-change-zeitraum-t…
hf-fvesely e234813
WIP adapt to new main and change zeitspanne to date and time
hf-fvesely 872cadc
Merge remote-tracking branch 'origin/main' into 714-change-zeitraum-t…
hf-fvesely a785a84
Fix duplicate link
hf-fvesely File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snsttr Hier sollten wir nochmal weiterdiskutieren wie eine sinnvolle Abbildung aussieeht. Evtl. Abgabefrist als Zeitpunkt und Bindefrist als Zeitmenge, oder Zeitspanne?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wie gehen wir damit um, wenn Felder sowohl eine Zeitspanne als eine Zeitmenge beinhalten könnten, also so wie die alte COM Zeitraum?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mögliche Lösung: Zeitraum doch noch drinlassen, als deprectaed markeiren, aber für manche Fälle noch drinlassen, wenn es wirklcih beides sein kann.
Alternativ: Felder duplizieren: abgabefristdauer, abgeabfristdatum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional["Zeitspanne | Zeitmenge"]
? Dafür gibt's doch den Union-type :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stimmt, in einer Diskussion mit Konstantin kam allerdings die Frage auf, ob das so eine gute Idee ist, da es nicht in allen Sprachen ein Pendant zum Union-type gibt.
Da es ja an mehreren Stellen Fristen gibt, kam mir noch die Idee ein COM Frist zu erstellen, was dann beide Optionen beinhaltet. Was denkt ihr? @lord-haffi @snsttr @hf-kklein @hf-krechan @hf-aschloegl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naja, in den JSON-Schemas wird der Any-Of type definiert, was genau der Union-type in Python ist. Wie die einzelnen Sprachen das Pattern dann umsetzen, ist ein Problem des Code-Generators imo. Bzw. desjenigen, der das dann implementiert. Da die Typen auch disjunkt sind, sehe ich da zumindest in der Theorie auch kein Problem, da nen Union draus zu machen.
@hf-kklein Was ist deine Meinung dazu?