-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bankverbindung #884
Open
FreddyFox892
wants to merge
8
commits into
main
Choose a base branch
from
FST/Issue879_Bankverbindung
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+84
−0
Open
Add Bankverbindung #884
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
39c87b3
Add Bankverbindung
FreddyFox892 fd63324
ka
FreddyFox892 cc2f306
test
FreddyFox892 648d26f
ka
FreddyFox892 5cff34e
fa1
FreddyFox892 4d33fd6
fix
FreddyFox892 9c81f0c
improve test
FreddyFox892 345112b
Merge branch 'main' into FST/Issue879_Bankverbindung
FreddyFox892 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
""" | ||
Contains Bankverbindung class and corresponding marshmallow schema for de-/serialization | ||
""" | ||
|
||
# pylint: disable=too-few-public-methods, too-many-instance-attributes | ||
# pylint: disable=no-name-in-module | ||
from typing import Optional | ||
|
||
from ..utils import postprocess_docstring | ||
from .com import COM | ||
|
||
|
||
@postprocess_docstring | ||
class Bankverbindung(COM): | ||
""" | ||
Eine Komponente zur Abbildung einer einzelner Bankverbindung | ||
|
||
.. raw:: html | ||
|
||
<object data="../_static/images/bo4e/com/Bankverbindung.svg" type="image/svg+xml"></object> | ||
|
||
.. HINT:: | ||
`Bankverbindung JSON Schema <https://json-schema.app/view/%23?url=https://raw.githubusercontent.com/BO4E/BO4E-Schemas/{__gh_version__}/src/bo4e_schemas/com/Bankverbindung.json>`_ | ||
|
||
""" | ||
|
||
iban: Optional[str] = None | ||
#: International Bank Account Number = IBAN z.B.: DE07 1234 1234 1234 1234 12 | ||
|
||
kontoinhaber: Optional[str] = None | ||
#: Juristische Person welche das Konto hält | ||
|
||
bankkennung: Optional[str] = None | ||
#: Ein eindeutiger Code, wie z.B. BIC (Bank Identifier Code) oder SWIFT-Code, der eine bestimmte Bank bei | ||
#: internationalen Transaktionen identifiziert (z.B. BIC: DEUTDEFF für die Deutsche Bank)." | ||
|
||
bankname: Optional[str] = None | ||
#: Name der bank z.B. Deutsche Bank |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import pytest | ||
|
||
from bo4e import Bankverbindung | ||
from tests.serialization_helper import assert_serialization_roundtrip | ||
|
||
|
||
class TestBankverbindung: | ||
@pytest.mark.parametrize( | ||
"bankverbindung", | ||
[ | ||
pytest.param( | ||
Bankverbindung( | ||
iban="DE07123412341234123412", | ||
kontoinhaber="Jürgen W.", | ||
bankkennung="DEUTDEFF", | ||
bankname="Deutsche Bank", | ||
), | ||
id="maximal attributes", | ||
), | ||
], | ||
) | ||
def test_serialization_roundtrip(self, bankverbindung: Bankverbindung) -> None: | ||
""" | ||
Test de-/serialisation of Ausschreibungslos | ||
""" | ||
assert_serialization_roundtrip(bankverbindung) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Das sollte alphabetisch einsortiert sein
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oder wird das hier irgendwie so autogeneriert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ne händisch, ich meine aber dass mir gesagt wurde dass das aber auto sortiert werden soll