Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename boa::Result to JsResult #1493

Merged
merged 4 commits into from
Aug 24, 2021
Merged

Rename boa::Result to JsResult #1493

merged 4 commits into from
Aug 24, 2021

Conversation

bartlomieju
Copy link
Contributor

Related to #1376

@Razican
Copy link
Member

Razican commented Aug 23, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,897 78,897 0
Passed 31,283 31,283 0
Ignored 15,612 15,612 0
Failed 32,002 32,002 0
Panics 2 2 0
Conformance 39.65% 39.65% 0.00%

@Razican Razican requested review from HalidOdat and Razican August 23, 2021 07:23
@Razican Razican added the enhancement New feature or request label Aug 23, 2021
@Razican Razican added this to the v0.13.0 milestone Aug 23, 2021
@Razican Razican added the API label Aug 23, 2021
@Razican Razican requested a review from RageKnify August 23, 2021 13:17
@HalidOdat HalidOdat mentioned this pull request Aug 23, 2021
Closed
@Razican Razican merged commit 42d8f20 into boa-dev:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@Razican Razican Razican approved these changes

@RageKnify RageKnify Awaiting requested review from RageKnify

Assignees
No one assigned
Labels
API enhancement New feature or request
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bartlomieju @Razican @HalidOdat