-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added MSRV check #3291
Added MSRV check #3291
Conversation
Can we read the root |
Test262 conformance changes
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3291 +/- ##
==========================================
- Coverage 50.32% 50.21% -0.11%
==========================================
Files 436 436
Lines 42604 42691 +87
==========================================
Hits 21439 21439
- Misses 21165 21252 +87 ☔ View full report in Codecov by Sentry. |
Second the idea regarding reading the version in the |
Will see how to do this this weekend :) |
@jedel1043, @nekevss this should be ready now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was double checking the run and noticed a deprecation warning. Maybe adjust it to use $GITHUB_OUTPUT
?
Co-authored-by: Kevin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This Pull Request is a follow-up of #3290.
It adds a test for the MSRV to the CI, so that we don't get similar issues in the future.