-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move arguments
object creation to bytecode
#3432
Conversation
Test262 conformance changes
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3432 +/- ##
==========================================
- Coverage 44.86% 44.83% -0.04%
==========================================
Files 487 488 +1
Lines 50373 50390 +17
==========================================
- Hits 22598 22590 -8
- Misses 27775 27800 +25
☔ View full report in Codecov by Sentry. |
arguments
object creation to opcodearguments
object creation to bytecode
8371337
to
8365701
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think this also puts us a step closer to separating codeblocks from the context, so that's good.
8365701
to
37a333b
Compare
37a333b
to
1571404
Compare
1571404
to
ff6e79b
Compare
Moves creation of
arguments
object creation from function internal methods, this allows us to remove the checks forarguments
object creation for functions that don't create it and would make #3194 easier since we can havearguments
be moves into the stack and accessed as a fast local, instead of accessing it through environments.While doing this I discovered a bug that happens when we create a function in
eval
, which was creating the functions and initializing the function, before theeval
environment'sPushDeclarativeEnvironment
is executed. Fixed by delaying creation of function by adding theCreateGlobalFunctionBinding
opcode.