Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PromiseCapability to stack #3528

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Move PromiseCapability to stack #3528

merged 3 commits into from
Dec 22, 2023

Conversation

HalidOdat
Copy link
Member

Depends on #3496

Moves the promise capability to stack. Reduces call frame for non-async functions by 48 bytes.

@HalidOdat HalidOdat added technical debt memory PRs and Issues related to the memory management or memory footprint. labels Dec 20, 2023
@HalidOdat HalidOdat added this to the v0.18.0 milestone Dec 20, 2023
Base automatically changed from refactor/vm-calling-convention to main December 20, 2023 17:11
@HalidOdat HalidOdat force-pushed the refactor/move-promise-capability-to-stack branch from de00c04 to 1f4dc1b Compare December 20, 2023 17:26
@github-actions GitHub Actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,960 95,960 0
Passed 76,534 76,534 0
Ignored 18,477 18,477 0
Failed 949 949 0
Panics 0 0 0
Conformance 79.76% 79.76% 0.00%

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2023 •
edited
Loading

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (c2f145c) 48.97% compared to head (f3a388a) 49.02%.
Report is 2 commits behind head on main.

Files Patch % Lines
core/engine/src/module/source.rs 0.00% 5 Missing ⚠️
core/engine/src/vm/call_frame/mod.rs 95.83% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3528      +/-   ##
==========================================
+ Coverage   48.97%   49.02%   +0.05%     
==========================================
  Files         471      471              
  Lines       48498    48550      +52     
==========================================
+ Hits        23752    23802      +50     
- Misses      24746    24748       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

raskad
raskad approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

core/engine/src/vm/call_frame/mod.rs Outdated Show resolved Hide resolved
jedel1043
jedel1043 approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@HalidOdat HalidOdat enabled auto-merge December 22, 2023 09:15
@HalidOdat HalidOdat added this pull request to the merge queue Dec 22, 2023
Merged via the queue into main with commit 0b37ad6 Dec 22, 2023
14 checks passed
@HalidOdat HalidOdat deleted the refactor/move-promise-capability-to-stack branch December 22, 2023 09:34
@HalidOdat HalidOdat mentioned this pull request Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@raskad raskad raskad approved these changes

Assignees
No one assigned
Labels
memory PRs and Issues related to the memory management or memory footprint. technical debt
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HalidOdat @raskad @jedel1043