Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Boa to be inline with Temporal #4034

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jasonwilliams
Copy link
Member

This PR brings Boa inline with the latest changes in Temporal

@jasonwilliams jasonwilliams added the Intl Changes related to the `Intl` implementation label Nov 10, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 3.79747% with 76 lines in your changes missing coverage. Please review.

Project coverage is 52.85%. Comparing base (6ddc2b4) to head (57b8c46).
Report is 292 commits behind head on main.

Files with missing lines Patch % Lines
...ore/engine/src/builtins/temporal/plain_date/mod.rs 4.54% 63 Missing ⚠️
...ore/engine/src/builtins/temporal/plain_time/mod.rs 0.00% 5 Missing ⚠️
...gine/src/builtins/temporal/plain_year_month/mod.rs 0.00% 4 Missing ⚠️
core/engine/src/builtins/temporal/instant/mod.rs 0.00% 2 Missing ⚠️
...ngine/src/builtins/temporal/plain_date_time/mod.rs 0.00% 1 Missing ⚠️
...ngine/src/builtins/temporal/plain_month_day/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4034      +/-   ##
==========================================
+ Coverage   47.24%   52.85%   +5.61%     
==========================================
  Files         476      483       +7     
  Lines       46892    46980      +88     
==========================================
+ Hits        22154    24832    +2678     
+ Misses      24738    22148    -2590     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me! I have a couple of nits that I would prefer are addressed, but nothing that is necessarily blocking.

I think there were a couple more updates in the temporal_rs mainly around ZonedDateTime. Were these still in the work?

core/engine/src/builtins/temporal/plain_month_day/mod.rs Outdated Show resolved Hide resolved
core/engine/src/builtins/temporal/plain_date/mod.rs Outdated Show resolved Hide resolved
@jasonwilliams
Copy link
Member Author

@nekevss i've cleaned up the comments and rebased, ill look at zonedDateTime in a follow up PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Intl Changes related to the `Intl` implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants