Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inline cache for getting bindings from the global object #4067

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add inline cache for getting bindings from the global object #4067

wants to merge 4 commits into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Dec 7, 2024

It changes the following:

  • Add inline cache for getting bindings from the global object

I saw a small performance increase when running the benchmarks for this patch.

@raskad raskad added the execution Issues or PRs related to code execution label Dec 7, 2024
@raskad raskad added this to the next-release milestone Dec 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2024 •
edited
Loading

Test262 conformance changes

Test result main count PR count difference
Total 48,625 48,625 0
Passed 43,616 43,616 0
Ignored 1,471 1,471 0
Failed 3,538 3,538 0
Panics 0 0 0
Conformance 89.70% 89.70% 0.00%

@raskad raskad requested a review from a team December 7, 2024 02:43
HalidOdat
HalidOdat approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat requested a review from a team December 9, 2024 13:26
0ex-d
0ex-d suggested changes Dec 13, 2024
View reviewed changes
Copy link

@0ex-d 0ex-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic addition

core/engine/src/vm/flowgraph/mod.rs Outdated Show resolved Hide resolved
core/engine/src/vm/code_block.rs Outdated Show resolved Hide resolved
hansl
hansl requested changes Dec 15, 2024
View reviewed changes
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit and after I can approve. Great work!

core/engine/src/vm/opcode/mod.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0ex-d 0ex-d 0ex-d requested changes

@hansl hansl hansl requested changes

@HalidOdat HalidOdat HalidOdat approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
execution Issues or PRs related to code execution
Projects
None yet
Milestone
next-release
Development

Successfully merging this pull request may close these issues.
4 participants
@raskad @hansl @0ex-d @HalidOdat