Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some string cleanups #4090

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

CrazyboyQCD
Copy link
Contributor

@CrazyboyQCD CrazyboyQCD commented Dec 18, 2024

  • Simplify JsString::as_str (miri passed, decrease the size of cli executable by ~5kb under release mode (28,680kb => 28,675kb) )
  • Replace soft deprecated addr_of* macro with & [const|mut] raw
  • Mark some &mut self tagged methods const(wait for 1.83)

@CrazyboyQCD CrazyboyQCD marked this pull request as ready for review December 18, 2024 02:31
@CrazyboyQCD CrazyboyQCD marked this pull request as draft December 18, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant