setTimeout, setInterval and clearInterval (and the same clearTimeout) implementations
#4130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imeout`) implementations This adds non-async implementations of the `setTimeout`/`setInterval` API functions. They are by default registered in the context when registering all APIs from `boa_runtime`.
jedel1043
requested changes
Jan 23, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4130 +/- ##
==========================================
+ Coverage 47.24% 54.68% +7.44%
==========================================
Files 476 492 +16
Lines 46892 49377 +2485
==========================================
+ Hits 22154 27002 +4848
+ Misses 24738 22375 -2363 ☔ View full report in Codecov by Sentry. |
This will add the capacity for the entire engine to mock time during tests. No impact on performance should be noticeable. Fixed boa-dev#4144
A negative duration is invalid.
nekevss
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds non-async implementations of the
setTimeout/setIntervalAPI functions. They are by default registered in the context when registering all APIs fromboa_runtime.This adds a new type of jobs that implement
HostEnqueueTimeoutJob(see https://tc39.es/ecma262/#sec-hostenqueuetimeoutjob).This requires #4141 to be merged first.