Reimplement Unit Group with different approach #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements the UnitGroup enum with a different approach to validation. Previously this was implemented, but it broke quite a few tests in Boa. I think that was partially due to a flawed implementation and a host of bugs that were previously present.
Those appear to have all been fixed with recent bug changes, and this reimplementation is primarily to address the broken tests in boa-dev/boa#4142 that require unit groups to be implemented.
The tests that the unit groups specifically address specifically are tests like: largestunit-invalid-string.js.