In the direction of #190 - fixing table format for PDF render #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nder proper in PDF format
bobbyiliev
approved these changes
Oct 9, 2021
|
Thank you for fixing this! This is a good catch! I will have to go through the chapters and correct that for all :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
As the title states, I've updated the
mstatcommand flag table so it will render properly in the PDF - just as an example. Actually, all over this Ebook a form of markdown tables (which is indeed valid form) is not being parsed correctly by ibis when rendered to PDF.Related Tickets & Documents
I've opened a ticket on ibis so that this other form of table format can be used:
themsaid/ibis#47
I believe creating a new parser on ibis to support the table format frequently used on this repo will be faster than going through and converting all the existing tables in this Ebook to the 'other' table format. 😄
An older issue on the ibis repo discussing the formatting currently possible with ibis for tables:
themsaid/ibis#27
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?