Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some GUI for Arnold #1

Open
wants to merge 262 commits into
base: master
Choose a base branch
from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Mar 24, 2021

  1. Configuration menu
    Copy the full SHA
    19099f6 View commit details
    Browse the repository at this point in the history
  2. Exported symbols for src/GafferScene

    boberfly authored and ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    af834ea View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4335e64 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    83a8f9f View commit details
    Browse the repository at this point in the history
  5. Exported symbols for src/GafferOSL

    boberfly authored and ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    74d5701 View commit details
    Browse the repository at this point in the history
  6. Exported symbols for src/GafferArnold

    boberfly authored and ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    2005307 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6776667 View commit details
    Browse the repository at this point in the history
  8. Add missing exports

    boberfly authored and ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    aa48413 View commit details
    Browse the repository at this point in the history
  9. GafferBindings exports

    boberfly authored and ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    01678ac View commit details
    Browse the repository at this point in the history
  10. GafferImage exports

    boberfly authored and ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    b816547 View commit details
    Browse the repository at this point in the history
  11. GafferScene exports

    boberfly authored and ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    b9ed234 View commit details
    Browse the repository at this point in the history
  12. GafferCortex exports

    boberfly authored and ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    884eb57 View commit details
    Browse the repository at this point in the history
  13. Missing header

    boberfly authored and ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    daee19d View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    796a257 View commit details
    Browse the repository at this point in the history
  15. Using std::numeric_limits instead of Imath::limits due to MSVC linkag…

    …e problem
    
    Representative error from MSVC:
    error LNK2019: unresolved external symbol "public: static unsigned __int64 __cdecl Imath_2_2::limits<unsigned __int64>::max(void)" (?m
    ax@?$limits@_K@Imath_2_2@@SA_KXZ) referenced in function "public: void __cdecl Gaffer::Switch<class Gaffer::ComputeNode>::setup(class Gaffer::Plug co
    nst *)"
    boberfly authored and ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    d0f951a View commit details
    Browse the repository at this point in the history
  16. 'and' to '&&'

    boberfly authored and ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    2189f24 View commit details
    Browse the repository at this point in the history
  17. Various MSVC fixes

    boberfly authored and ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    0dfe5e2 View commit details
    Browse the repository at this point in the history
  18. Public/private workaround for MSVC

    error C2248: 'GafferImageUI::ImageGadget::TileIndex': cannot access private struct declared in class 'GafferImageUI::ImageGadget'
    boberfly authored and ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    9d669e8 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    7df2c13 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    033b08a View commit details
    Browse the repository at this point in the history
  21. Python fixes/workarounds for windows

    boberfly authored and ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    36bba38 View commit details
    Browse the repository at this point in the history
  22. msvc can't compile with IMath

    ArrayPlug.obj : error LNK2019: unresolved external symbol "public: static unsigned __int64 __cdecl Imath_2_2::limits<unsigned __int64>::max(void)" (?max@?$limits@_K@Imath_2_2@@SA_KXZ) referenced in function "public: void __cdecl Gaffer::ArrayPlug::`default constructor closure'(void)"
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    4c9aed9 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    89f9063 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    7807a26 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    e8f4d6a View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    93ac4b2 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    1b78236 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    67e3228 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    87b508e View commit details
    Browse the repository at this point in the history
  30. MSVC needs boost namespace specified

    error C2872: 'list': ambiguous symbol
    'std::list': class has no constructors
    'boost::python::ssize_t boost::python::len(const boost::python::api::object &)': cannot convert argument 1 from 'std::list' to 'const boost::python::api::object &'
    binary '[': 'std::list' does not define this operator or a conversion to a type acceptable to the predefined operator
    'arg': ambiguous symbol
    'std::arg': no matching overloaded function found
    '_Promote_to_float<_Ty>::type std::arg(_Ty)': could not deduce template argument for '<unnamed-symbol>'
    '_Ty std::arg(const std::complex<_Other> &)': could not deduce template argument for 'const std::complex<_Other> &' from 'const char [5]'
    '_Ty std::arg(const std::complex<_Other> &)': could not deduce template argument for 'const std::complex<_Other> &' from 'const char [10]'
    '_Ty std::arg(const std::complex<_Other> &)': could not deduce template argument for 'const std::complex<_Other> &' from 'const char [6]'
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    e9e2e3b View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    291d0e9 View commit details
    Browse the repository at this point in the history
  32. On Windows filename().c_str() is a wchar_t so we need an extra conver…

    …sion to solve the error:
    
    error C2664: 'long strtol(const char *,char **,int)': cannot convert argument 1 from 'const boost::filesystem::path::value_type *' to 'const char *'
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    ffac534 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    5a674bf View commit details
    Browse the repository at this point in the history
  34. all code lives in the header so remove the export. With the GAFFER_EX…

    …PORT in MSVC gives errors like
    
    'Gaffer::Container<Base,T>::typeId': definition of dllimport function not allowed (compili
    ng source file M:\gaffer\src\GafferModule\NodeBinding.cpp)
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    f6f968a View commit details
    Browse the repository at this point in the history
  35. export missing symbols

    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    7358104 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    68d0cee View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    7e7e21f View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    911d15e View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    d2b0154 View commit details
    Browse the repository at this point in the history
  40. Revert "change readonly testing to be cross-platform"

    This reverts commit 23a2ae5.
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    b081569 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    c82988c View commit details
    Browse the repository at this point in the history
  42. fix readonly test

    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    02288ef View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    e27b43b View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    d9fe5c7 View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    0686c52 View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    a48fa4f View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    af85159 View commit details
    Browse the repository at this point in the history
  48. get test running (and failing) on Windows

    Windows Python doesn't have pwd or grp modules, so exclude them on Windows
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    db05a52 View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    88032c5 View commit details
    Browse the repository at this point in the history
  50. add test to make sure the owner is not empty (this was causing a fals…

    …e pass in the Owner test on Windows before adapting FileSystemPath.cpp to Windows)
    
    add workaround on Windows to get the file owner - Python does not have a reliable native function for this
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    09d8692 View commit details
    Browse the repository at this point in the history
  51. Windows can't delete the temp folder (in the GafferTest.TestCase.tear…

    …Down function) because the test is still working in that directory, resulting in an error
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    85c35a8 View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    22a57dd View commit details
    Browse the repository at this point in the history
  53. convert existing tests to work cross-platform

    add tests for nativeStrings
    create separate function to get file owner cross-platform since it is used multiple times
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    059511f View commit details
    Browse the repository at this point in the history
  54. fix typo

    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    4e76a91 View commit details
    Browse the repository at this point in the history
  55. add nativeString function to return path values conforming to OS requ…

    …irements for Windows and Linux / Mac
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    72eca0e View commit details
    Browse the repository at this point in the history
  56. Configuration menu
    Copy the full SHA
    55c5f8d View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    790b4e8 View commit details
    Browse the repository at this point in the history
  58. Leaving out symlink support on Windows (it's only available to admini…

    …strators by default, and boost does not support it either), just test that the regular file is valid
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    7d82b7c View commit details
    Browse the repository at this point in the history
  59. dump sanitizing string in favor of overriding the setFromString to al…

    …low for properly setting the root, especially with Windows drive letter paths
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    1945995 View commit details
    Browse the repository at this point in the history
  60. Configuration menu
    Copy the full SHA
    33b99f4 View commit details
    Browse the repository at this point in the history
  61. add Windows code to get file owner. Note that the file owner related …

    …tests are failing - this is a problem with Python not being able to get a directory owner properly. Currently looking into how to do this
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    2f4eea7 View commit details
    Browse the repository at this point in the history
  62. fix UNC paths - need to make sure nativePath starts with "\\" and tha…

    …t we are not omitting the leading "/" because of errors in string parsing
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    ab11be3 View commit details
    Browse the repository at this point in the history
  63. Configuration menu
    Copy the full SHA
    1235d1b View commit details
    Browse the repository at this point in the history
  64. Configuration menu
    Copy the full SHA
    a099a4f View commit details
    Browse the repository at this point in the history
  65. Revert "use full path text to include the root, which on Windows may …

    …be the drive letter"
    
    This reverts commit 5ee4212.
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    afe7070 View commit details
    Browse the repository at this point in the history
  66. Configuration menu
    Copy the full SHA
    4dfef49 View commit details
    Browse the repository at this point in the history
  67. Configuration menu
    Copy the full SHA
    015191a View commit details
    Browse the repository at this point in the history
  68. Configuration menu
    Copy the full SHA
    2d53435 View commit details
    Browse the repository at this point in the history
  69. fix typo from last commit

    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    6271744 View commit details
    Browse the repository at this point in the history
  70. Configuration menu
    Copy the full SHA
    c6d098c View commit details
    Browse the repository at this point in the history
  71. Configuration menu
    Copy the full SHA
    a585120 View commit details
    Browse the repository at this point in the history
  72. Configuration menu
    Copy the full SHA
    4b61bbc View commit details
    Browse the repository at this point in the history
  73. Revert "add simple test to check truncating"

    This reverts commit 5431412.
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    73bc22a View commit details
    Browse the repository at this point in the history
  74. Configuration menu
    Copy the full SHA
    a9eeb71 View commit details
    Browse the repository at this point in the history
  75. Configuration menu
    Copy the full SHA
    6c93ce4 View commit details
    Browse the repository at this point in the history
  76. fix OSL expressions not working because it wasn't splitting the OSL p…

    …ath environment variable correctly on windows
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    1828317 View commit details
    Browse the repository at this point in the history
  77. Configuration menu
    Copy the full SHA
    00a1388 View commit details
    Browse the repository at this point in the history
  78. export for Windows linking

    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    328f6c3 View commit details
    Browse the repository at this point in the history
  79. correct cmake syntax

    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    1956d48 View commit details
    Browse the repository at this point in the history
  80. Configuration menu
    Copy the full SHA
    47ad421 View commit details
    Browse the repository at this point in the history
  81. Revert "convert OSL shader searching to cross platform"

    This reverts commit 219ecda.
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    1a2df38 View commit details
    Browse the repository at this point in the history
  82. handle Windows paths properly for OSL shaders and conform to forward …

    …slash standard for shader paths
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    b6b5b17 View commit details
    Browse the repository at this point in the history
  83. Configuration menu
    Copy the full SHA
    9e557ea View commit details
    Browse the repository at this point in the history
  84. Configuration menu
    Copy the full SHA
    d51923b View commit details
    Browse the repository at this point in the history
  85. Configuration menu
    Copy the full SHA
    5620ea3 View commit details
    Browse the repository at this point in the history
  86. Configuration menu
    Copy the full SHA
    cc33364 View commit details
    Browse the repository at this point in the history
  87. Exported symbols for src/GafferCortex

    boberfly authored and ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    561d253 View commit details
    Browse the repository at this point in the history
  88. Exported symbols for src/GafferImage

    boberfly authored and ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    b13f1ad View commit details
    Browse the repository at this point in the history
  89. Add missing exports

    boberfly authored and ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    0d8943c View commit details
    Browse the repository at this point in the history
  90. GafferImage exports

    boberfly authored and ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    400ad40 View commit details
    Browse the repository at this point in the history
  91. GafferCortex exports

    boberfly authored and ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    d19ae19 View commit details
    Browse the repository at this point in the history
  92. Missing header

    boberfly authored and ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    09d4808 View commit details
    Browse the repository at this point in the history
  93. Configuration menu
    Copy the full SHA
    32fbf8d View commit details
    Browse the repository at this point in the history
  94. Configuration menu
    Copy the full SHA
    4f202ea View commit details
    Browse the repository at this point in the history
  95. Configuration menu
    Copy the full SHA
    855aaff View commit details
    Browse the repository at this point in the history
  96. Revert "change readonly testing to be cross-platform"

    This reverts commit 23a2ae5.
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    eadaa4b View commit details
    Browse the repository at this point in the history
  97. Configuration menu
    Copy the full SHA
    543f49b View commit details
    Browse the repository at this point in the history
  98. Configuration menu
    Copy the full SHA
    b40abb5 View commit details
    Browse the repository at this point in the history
  99. add test to make sure the owner is not empty (this was causing a fals…

    …e pass in the Owner test on Windows before adapting FileSystemPath.cpp to Windows)
    
    add workaround on Windows to get the file owner - Python does not have a reliable native function for this
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    70ac8ae View commit details
    Browse the repository at this point in the history
  100. Windows can't delete the temp folder (in the GafferTest.TestCase.tear…

    …Down function) because the test is still working in that directory, resulting in an error
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    da5b20b View commit details
    Browse the repository at this point in the history
  101. Configuration menu
    Copy the full SHA
    4efaca1 View commit details
    Browse the repository at this point in the history
  102. convert existing tests to work cross-platform

    add tests for nativeStrings
    create separate function to get file owner cross-platform since it is used multiple times
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    06d383d View commit details
    Browse the repository at this point in the history
  103. Configuration menu
    Copy the full SHA
    be29a35 View commit details
    Browse the repository at this point in the history
  104. fix UNC paths - need to make sure nativePath starts with "\\" and tha…

    …t we are not omitting the leading "/" because of errors in string parsing
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    b4ea8a5 View commit details
    Browse the repository at this point in the history
  105. Configuration menu
    Copy the full SHA
    684961f View commit details
    Browse the repository at this point in the history
  106. Revert "use full path text to include the root, which on Windows may …

    …be the drive letter"
    
    This reverts commit 5ee4212.
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    4362291 View commit details
    Browse the repository at this point in the history
  107. Configuration menu
    Copy the full SHA
    1233cb1 View commit details
    Browse the repository at this point in the history
  108. Revert "add simple test to check truncating"

    This reverts commit 5431412.
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    c006d24 View commit details
    Browse the repository at this point in the history
  109. Configuration menu
    Copy the full SHA
    d5b34af View commit details
    Browse the repository at this point in the history
  110. correct cmake syntax

    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    926f37a View commit details
    Browse the repository at this point in the history
  111. Configuration menu
    Copy the full SHA
    c2aba93 View commit details
    Browse the repository at this point in the history
  112. Configuration menu
    Copy the full SHA
    bbee0cd View commit details
    Browse the repository at this point in the history
  113. Configuration menu
    Copy the full SHA
    00c1570 View commit details
    Browse the repository at this point in the history
  114. Configuration menu
    Copy the full SHA
    a482eb7 View commit details
    Browse the repository at this point in the history
  115. Configuration menu
    Copy the full SHA
    770700f View commit details
    Browse the repository at this point in the history
  116. Configuration menu
    Copy the full SHA
    3f76ba9 View commit details
    Browse the repository at this point in the history
  117. Configuration menu
    Copy the full SHA
    044a14c View commit details
    Browse the repository at this point in the history
  118. Configuration menu
    Copy the full SHA
    d664a72 View commit details
    Browse the repository at this point in the history
  119. Configuration menu
    Copy the full SHA
    654e868 View commit details
    Browse the repository at this point in the history
  120. on Windows the %GAFFER_ROOT% variable contains a parent directory (..…

    …) element that needs to be expanded
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    aeca1d1 View commit details
    Browse the repository at this point in the history
  121. Configuration menu
    Copy the full SHA
    ab23fd9 View commit details
    Browse the repository at this point in the history
  122. UserPlugs : add FileSystemPathPlug and set default widget to FileSyst…

    …emPathPlugValueWidget
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    33459de View commit details
    Browse the repository at this point in the history
  123. Configuration menu
    Copy the full SHA
    ae9aa4b View commit details
    Browse the repository at this point in the history
  124. Configuration menu
    Copy the full SHA
    86857cd View commit details
    Browse the repository at this point in the history
  125. Configuration menu
    Copy the full SHA
    87051f1 View commit details
    Browse the repository at this point in the history
  126. Configuration menu
    Copy the full SHA
    9fe7213 View commit details
    Browse the repository at this point in the history
  127. Gaffer Windows : make sure the built-in Python is used and handle err…

    …or return codes appropriately
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    3ec0306 View commit details
    Browse the repository at this point in the history
  128. Windows Build : use JOM for faster builds

    - MSVC make doesn't use multiple threads
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    9083658 View commit details
    Browse the repository at this point in the history
  129. Configuration menu
    Copy the full SHA
    421b869 View commit details
    Browse the repository at this point in the history
  130. Configuration menu
    Copy the full SHA
    c592736 View commit details
    Browse the repository at this point in the history
  131. remove artifacts archive so it isn't packaged with release

    install inkscape for building graphics
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    4ca7932 View commit details
    Browse the repository at this point in the history
  132. Configuration menu
    Copy the full SHA
    95f94e1 View commit details
    Browse the repository at this point in the history
  133. gaffer.bat : refactor to prepend / append environment variables

    This helps particularly with conditionals that batch files treat with a different syntax
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    01bdea5 View commit details
    Browse the repository at this point in the history
  134. Configuration menu
    Copy the full SHA
    1174986 View commit details
    Browse the repository at this point in the history
  135. Configuration menu
    Copy the full SHA
    b63acc1 View commit details
    Browse the repository at this point in the history
  136. Configuration menu
    Copy the full SHA
    da63c7e View commit details
    Browse the repository at this point in the history
  137. Configuration menu
    Copy the full SHA
    7d0d648 View commit details
    Browse the repository at this point in the history
  138. Revert "Windows Build : remove conditional Arnold building"

    This reverts commit 8aa6980.
    
    # Conflicts:
    #	contrib/cmake/CMakeLists.txt
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    8586053 View commit details
    Browse the repository at this point in the history
  139. Configuration menu
    Copy the full SHA
    8cd76d1 View commit details
    Browse the repository at this point in the history
  140. Configuration menu
    Copy the full SHA
    df284c1 View commit details
    Browse the repository at this point in the history
  141. Configuration menu
    Copy the full SHA
    fcd2017 View commit details
    Browse the repository at this point in the history
  142. Configuration menu
    Copy the full SHA
    2adb6f3 View commit details
    Browse the repository at this point in the history
  143. Configuration menu
    Copy the full SHA
    39d5246 View commit details
    Browse the repository at this point in the history
  144. Gaffer.bat : split Appleseed shader setup into separate blocks

    Batch files look at the contents of an if statement as one single command. If OSL_SEARCH_PATHS is set in the same block as the APPLESEED_SEARCHPATH, the latter won't find the paths added to OSL_SEARCH_PATHS
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    ba126b0 View commit details
    Browse the repository at this point in the history
  145. Configuration menu
    Copy the full SHA
    a403e32 View commit details
    Browse the repository at this point in the history
  146. Process : include declarations for Plug and Context

    MSVC is not able to cast Gaffer::Plug and Gaffer::Context to IECore::RefCounted unless their declarations are included
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    5cfa29d View commit details
    Browse the repository at this point in the history
  147. Windows : add symbol exports

    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    2f86043 View commit details
    Browse the repository at this point in the history
  148. Configuration menu
    Copy the full SHA
    24ad4e0 View commit details
    Browse the repository at this point in the history
  149. Configuration menu
    Copy the full SHA
    06030e5 View commit details
    Browse the repository at this point in the history
  150. GafferArnoldUI : add symbol exports

    - Symbols for GafferArnoldUI need to be exported
    - MSVC2017 prevents unnamed namespaces from being exported, so exports need to be in a named namespace
    - MSVC gives an error with multiple definitions of 'parameterOrDefault' found in multiple source files when linking
    - Isolate 'parameterOrDefault' to individual namespaces as a short-term fix before refactoring
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    4b0de70 View commit details
    Browse the repository at this point in the history
  151. DocumentationAlgo : adapt parameters for MSVC

    - The second argument to markdown_to_html is 'size_t len' which MSVC defines as unsigned int64
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    514b30e View commit details
    Browse the repository at this point in the history
  152. Gaffer.bat : fix typo

    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    0ca6d18 View commit details
    Browse the repository at this point in the history
  153. Configuration menu
    Copy the full SHA
    2b3b1ec View commit details
    Browse the repository at this point in the history
  154. Configuration menu
    Copy the full SHA
    e7ebe1f View commit details
    Browse the repository at this point in the history
  155. Configuration menu
    Copy the full SHA
    4ef20d6 View commit details
    Browse the repository at this point in the history
  156. Configuration menu
    Copy the full SHA
    1c784b0 View commit details
    Browse the repository at this point in the history
  157. Configuration menu
    Copy the full SHA
    6b29586 View commit details
    Browse the repository at this point in the history
  158. Configuration menu
    Copy the full SHA
    274f7b0 View commit details
    Browse the repository at this point in the history
  159. Scons : adapt Python naming convention to Windows scheme

    - Python names it's library as python<versionMajor><versionMinor>.lib with no dots in the version number
    - The Python include directory does not include a version number
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    481e306 View commit details
    Browse the repository at this point in the history
  160. Scons : Quote Inkscape command to allow spaces in the path

    - Inkscape on Windows is likely installed in "C:\Program Files" - the space in the directory name requires quoting to be run
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    e27f436 View commit details
    Browse the repository at this point in the history
  161. Scons : convert LOCATE_DEPENDENCY_PATH to a list if it is not already

    - MSVC builds need to have the Boost include directory pointed out, this seems like the most logical way and supports additional directories passed on the command line if needed
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    17951a2 View commit details
    Browse the repository at this point in the history
  162. Configuration menu
    Copy the full SHA
    e69d6d9 View commit details
    Browse the repository at this point in the history
  163. Configuration menu
    Copy the full SHA
    1fb5d52 View commit details
    Browse the repository at this point in the history
  164. Configuration menu
    Copy the full SHA
    5f4aaab View commit details
    Browse the repository at this point in the history
  165. Configuration menu
    Copy the full SHA
    3cf5e3f View commit details
    Browse the repository at this point in the history
  166. Configuration menu
    Copy the full SHA
    3802dd8 View commit details
    Browse the repository at this point in the history
  167. Configuration menu
    Copy the full SHA
    82c81c8 View commit details
    Browse the repository at this point in the history
  168. Configuration menu
    Copy the full SHA
    f99b862 View commit details
    Browse the repository at this point in the history
  169. Configuration menu
    Copy the full SHA
    c3590ab View commit details
    Browse the repository at this point in the history
  170. Configuration menu
    Copy the full SHA
    9616023 View commit details
    Browse the repository at this point in the history
  171. Configuration menu
    Copy the full SHA
    7f253da View commit details
    Browse the repository at this point in the history
  172. Configuration menu
    Copy the full SHA
    3483b88 View commit details
    Browse the repository at this point in the history
  173. Scons : set optimizations in RelWithDebugInfo build

    - there was a problem with visibility of the IECoreGL::PerspectiveCamera since it only lives in an include file with no corresponding .cpp file. I'm not entirely sure why this works, maybe the optimization does some form of inlining?
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    19c9e1a View commit details
    Browse the repository at this point in the history
  174. Configuration menu
    Copy the full SHA
    c577edd View commit details
    Browse the repository at this point in the history
  175. Configuration menu
    Copy the full SHA
    facfe73 View commit details
    Browse the repository at this point in the history
  176. Configuration menu
    Copy the full SHA
    6450b6a View commit details
    Browse the repository at this point in the history
  177. Configuration menu
    Copy the full SHA
    ebcf128 View commit details
    Browse the repository at this point in the history
  178. Configuration menu
    Copy the full SHA
    65f976b View commit details
    Browse the repository at this point in the history
  179. Configuration menu
    Copy the full SHA
    697428d View commit details
    Browse the repository at this point in the history
  180. Configuration menu
    Copy the full SHA
    bf40612 View commit details
    Browse the repository at this point in the history
  181. Catalogue : force substitutions

    - override Process::current() check in FileSystemPathPlug
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    7e26e78 View commit details
    Browse the repository at this point in the history
  182. Configuration menu
    Copy the full SHA
    62c9e66 View commit details
    Browse the repository at this point in the history
  183. Configuration menu
    Copy the full SHA
    6f5be51 View commit details
    Browse the repository at this point in the history
  184. Configuration menu
    Copy the full SHA
    53b1e4c View commit details
    Browse the repository at this point in the history
  185. Configuration menu
    Copy the full SHA
    a9ffbb2 View commit details
    Browse the repository at this point in the history
  186. Use std::numeric_limits for size_t

    - Windows defines size_t as unsigned __int64 which OpenEXR does not have a template specialization for
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    c3143f8 View commit details
    Browse the repository at this point in the history
  187. Configuration menu
    Copy the full SHA
    0f83737 View commit details
    Browse the repository at this point in the history
  188. Configuration menu
    Copy the full SHA
    43fc73d View commit details
    Browse the repository at this point in the history
  189. Configuration menu
    Copy the full SHA
    7ab6d4c View commit details
    Browse the repository at this point in the history
  190. Configuration menu
    Copy the full SHA
    f0945ba View commit details
    Browse the repository at this point in the history
  191. GafferArnoldUI : link to Arnold lib

    - needed to locate ai.lib on Windows
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    001d391 View commit details
    Browse the repository at this point in the history
  192. Configuration menu
    Copy the full SHA
    cb66542 View commit details
    Browse the repository at this point in the history
  193. SConstruct : add option for Boost Python library suffix

    - Boost on Windows adds the Python version to the boost_python library
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    f9b1cbf View commit details
    Browse the repository at this point in the history
  194. Configuration menu
    Copy the full SHA
    d1e6228 View commit details
    Browse the repository at this point in the history
  195. GoboVisualiser : fix rebase

    - it is necessary to add the non-anonymous namespace to avoid compiler error C2201: https://docs.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/compiler-error-c2201?view=vs-2019
    - static data in an anonymous namespace will get internal linkage, but LightFilterVisualiser comes from IECoreGLPreview which requires external linkage to access
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    14959a5 View commit details
    Browse the repository at this point in the history
  196. Configuration menu
    Copy the full SHA
    de17396 View commit details
    Browse the repository at this point in the history
  197. Stats : add Windows Max resident size reporting

    "resource" module is not available on Windows and it appears the best native Python method of getting MaxRSS is through the pywin32 extension which would introduce a new dependency. Using a subprocess command and parsing the output is a simple alternative since performance is not critical here.
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    81233a6 View commit details
    Browse the repository at this point in the history
  198. gaffer.bat : add debug support

    - There is no reliable method of getting the "devenv" executable path, and it isn't added to PATH during installation. We rely on the user setting the GAFFER_DEBUGGER to the full path, including "devenv".
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    b205686 View commit details
    Browse the repository at this point in the history
  199. Configuration menu
    Copy the full SHA
    6775ffb View commit details
    Browse the repository at this point in the history
  200. Configuration menu
    Copy the full SHA
    a6fb058 View commit details
    Browse the repository at this point in the history
  201. TypedObjectPlug : don't use "extern" on Windows

    - Marking variables as "extern" in MSVC generates this warning: https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4910?view=msvc-160
    - The "extern"s were introduced to fix a Mac error, so it is safe, and desireable, to exclude these on Windows (ImageEngine/cortex@d6d9e78#diff-bb99ebf651102989cbabc86eb2c276d7f986964d779a679c3541f8be14e21615)
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    3d8d8c3 View commit details
    Browse the repository at this point in the history
  202. TypedObjectPlugBinding : fix error when compiling on MSVC with "/perm…

    …issive-"
    
    - MSVC was erroring with: include\gafferbindings\typedobjectplugbinding.inl(156): error C2064: term does not evaluate to a function taking 0 arguments
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    4a6d91a View commit details
    Browse the repository at this point in the history
  203. Gaffer.bat : disable Jemalloc.bat by default (Windows only)

    It seems Jemalloc is not tested extensively on Windows (according to Github discussions including the developers) and Github issues suggest stability across major versions can be spotty. DCCs like Houdini also only use Jemalloc on Linux so we're in good company.
    
    The 5.2.1 (Gaffer is on 3.6 for stability reasons) release focuses on Windows so perhaps in future upgrades this can be enabled by default.
    ericmehl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    fcb70b0 View commit details
    Browse the repository at this point in the history
  204. Configuration menu
    Copy the full SHA
    597f584 View commit details
    Browse the repository at this point in the history
  205. Configuration menu
    Copy the full SHA
    91115bc View commit details
    Browse the repository at this point in the history
  206. Configuration menu
    Copy the full SHA
    0be86db View commit details
    Browse the repository at this point in the history
  207. Configuration menu
    Copy the full SHA
    dc468c5 View commit details
    Browse the repository at this point in the history
  208. Configuration menu
    Copy the full SHA
    6ceffe5 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. GafferSceneUI : fix utf-8 errors on Windows

    There seems to be an encoding mismatch when importing Python files with certain utf-8 characters where the files are assumed to have cp1252 encoding which can't convert some characters to utf-8. Even forcing the file to be saved as utf-8 does not fix the problem. Replacing "real" utf-8 characters (wysiwyg in a text editor) with the equivalent utf-8 code solves this.
    ericmehl committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    757356e View commit details
    Browse the repository at this point in the history
  2. ScriptNodeBinding : remove AST processing in tolerantExec

    - AST is not available on Windows without a patched, customized Python build.
    - This comes from the experimental implementation in johnhaddon@c817cf6
    - Note that it introduces a performance regression for loading scripts vs. the AST implementation.
    ericmehl committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    15bd37d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d39b308 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a158dfa View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Merge pull request #29 from ericmehl/gaffer_0.59.6.0

    Gaffer Windows 0.59.6.0 and Python 3
    ericmehl authored Mar 30, 2021
    Configuration menu
    Copy the full SHA
    90b43b6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d05c3ed View commit details
    Browse the repository at this point in the history
  3. Merge pull request #30 from hypothetical-inc/revert-29-gaffer_0.59.6.0

    Revert "Gaffer Windows 0.59.6.0 and Python 3"
    ericmehl authored Mar 30, 2021
    Configuration menu
    Copy the full SHA
    3066fa3 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Configuration menu
    Copy the full SHA
    720b46d View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. Configuration menu
    Copy the full SHA
    7da6314 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. Configuration menu
    Copy the full SHA
    127aa8d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ea903de View commit details
    Browse the repository at this point in the history
  3. Merge pull request GafferHQ#4482 from andrewkaufman/ieConfigs

    IE Configs : Limit builds to Arnold 6
    andrewkaufman authored Nov 19, 2021
    Configuration menu
    Copy the full SHA
    2a5e176 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. Configuration menu
    Copy the full SHA
    e42fe45 View commit details
    Browse the repository at this point in the history
  2. OSLCode : Check for empty .oso files

    Despite AcademySoftwareFoundation/OpenShadingLanguage#1360, we have still seen one example of an empty `.oso` file being produced in production. Adding further checks will hopefully help us get to the bottom of it if it happens again.
    johnhaddon committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    a8354ba View commit details
    Browse the repository at this point in the history
  3. BranchCreator : Fix unnecessary input bounds evaluation

    We were doing a complete (and completely unnecessary) recursive bounds evaluation of `/GAFFERBOT` when creating a branch at `/children`. In this case, `branchesData->locationOrAncestor( "/GAFFERBOT" )` correctly returned the root location, but we incorrectly interpreted that as meaning that `/GAFFERBOT` was an ancestor of the branch. If `path` is deeper than `location`, then path _cannot_ be the ancestor of a branch.
    johnhaddon committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    9543ac2 View commit details
    Browse the repository at this point in the history
  4. Merge pull request GafferHQ#4485 from johnhaddon/oslCodeChecks

    OSLCode : Check for empty `.oso` files
    johnhaddon authored Nov 22, 2021
    Configuration menu
    Copy the full SHA
    a704f7b View commit details
    Browse the repository at this point in the history
  5. Merge pull request GafferHQ#4486 from johnhaddon/branchCreatorBoundsFix

    BranchCreator : Fix unnecessary input bounds evaluation
    johnhaddon authored Nov 22, 2021
    Configuration menu
    Copy the full SHA
    199fbed View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Install : Allow updating an existing install tree

    At IE we often re-run an installation script and run into failures because the top level directory exists. This has been an annoyance in the past, but now that Arnold installs to subdirectories this becomes more problematic.
    andrewkaufman committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    4ae5832 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    694a9ed View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. Merge pull request GafferHQ#4487 from andrewkaufman/installUpdates

    Install : Allow updating an existing install tree
    johnhaddon authored Nov 24, 2021
    Configuration menu
    Copy the full SHA
    12ab772 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    53ab0eb View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2021

  1. Merge pull request GafferHQ#4489 from johnhaddon/overlayWheelFix

    GadgetWidget : Don't steal wheel events from overlay widgets
    johnhaddon authored Nov 25, 2021
    Configuration menu
    Copy the full SHA
    f973ecc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ac4712 View commit details
    Browse the repository at this point in the history
  3. Merge pull request GafferHQ#4488 from johnhaddon/columnAt

    PathListingWidget : Add `columnAt()` method
    johnhaddon authored Nov 25, 2021
    Configuration menu
    Copy the full SHA
    e3bcd0a View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2021

  1. Configuration menu
    Copy the full SHA
    bc493bf View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. Configuration menu
    Copy the full SHA
    b002ed2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    92d0eb5 View commit details
    Browse the repository at this point in the history
  3. Merge pull request GafferHQ#4494 from danieldresser-ie/focusFix

    Gaffer 0.61 UI Fixes
    johnhaddon authored Nov 29, 2021
    Configuration menu
    Copy the full SHA
    c7d8bca View commit details
    Browse the repository at this point in the history
  4. Merge pull request GafferHQ#4495 from johnhaddon/pathListingWidgetFix

    PathListingWidget : Fix unwanted expansion when clicking to select
    johnhaddon authored Nov 29, 2021
    Configuration menu
    Copy the full SHA
    c297d00 View commit details
    Browse the repository at this point in the history
  5. Bump version to 0.60.12.1

    johnhaddon committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    a4e005b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    37d7f57 View commit details
    Browse the repository at this point in the history
  7. Bump version to 0.61.1.0

    johnhaddon committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    35491ad View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. Fixed patch version

    This should have been bumped _before_ 0.60.12.1 was tagged. Not sure if we want to force re-tag or release 0.60.12.2 (making this commit a bit silly)
    andrewkaufman authored Nov 30, 2021
    Configuration menu
    Copy the full SHA
    562ba67 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. Configuration menu
    Copy the full SHA
    baa41cc View commit details
    Browse the repository at this point in the history
  2. Arnold Renderer : Destroy AOV shaders before universe

    We had been getting away with this up till now, but Arnold 7 is less forgiving and crashes when a node is destroyed after its universe. Strangely, our existing `RendererTest.testAOVShaders` didn't catch this crash, but it reproduced every time when rendering via the GUI.
    johnhaddon committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    74b8f9c View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2021

  1. Merge pull request GafferHQ#4498 from johnhaddon/versionCheck

    CI : Check SConstruct version matches tag version
    johnhaddon authored Dec 3, 2021
    Configuration menu
    Copy the full SHA
    95d3bf2 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2021

  1. Configuration menu
    Copy the full SHA
    49b6772 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. Merge pull request GafferHQ#4499 from johnhaddon/arnold7Crash

    Arnold Renderer : Destroy AOV shaders before universe
    johnhaddon authored Dec 7, 2021
    Configuration menu
    Copy the full SHA
    877b574 View commit details
    Browse the repository at this point in the history
  2. Merge pull request GafferHQ#4502 from danieldresser-ie/luminanceDoc

    Doc : ControlsAndShortcuts : Add doc for Luminance hotkey
    johnhaddon authored Dec 7, 2021
    Configuration menu
    Copy the full SHA
    13320d0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bf4d482 View commit details
    Browse the repository at this point in the history
  4. Bump version to 0.61.1.1

    johnhaddon committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    4c7596f View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2022

  1. Configuration menu
    Copy the full SHA
    813762b View commit details
    Browse the repository at this point in the history