Introduce Schemas to handle missing body, empty transaction list, missing fields, additional date formats #48
+143
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…p-py into discord-reported-issues
for more information, see https://pre-commit.ci
|
Transactions can now handle multiple date formats:
|
MattFaz
changed the title
…get_api_key checks, use default uuid package
for more information, see https://pre-commit.ci
MattFaz
commented
Nov 25, 2024
| @@ -20,9 +16,3 @@ async def get_api_key(api_key_header: str = Security(api_key_header)): | |||
| status_code=403, | |||
| detail="Could not validate credentials", | |||
| ) | |||
|
|
|||
|
|
|||
| def generate_custom_id(): | |||
There was a problem hiding this comment.
Removed as its only used in 1 function, and we can use the default python uuid library
MattFaz
commented
Nov 25, 2024
| from services.actual_service import actual_service | ||
|
|
||
| router = APIRouter() | ||
|
|
||
|
|
||
| @router.post("/transactions", dependencies=[Depends(get_api_key)]) |
There was a problem hiding this comment.
Removed as /transaction and /transactions/ will work regardless, no need to add both.
Additionally we do not need the dependency on get_api_key here as it's already added in main.py when we add the route
|
@bobokun happy to discuss anything here :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Schema functionality to allow easier validating of requests and responses.
No body, missing transactions, or missing fields will now return appropriate error messages (see screenshots attached).