This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
A large rewrite for Piface Control & Display and Your inspiration #1
Open
keinstein
wants to merge
30
commits into
bobrathbone:master
Choose a base branch
from
keinstein:tsradio
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The structure of the original radio does not fit very well with the idea of navigating through the “directories” of mpd. A further incompatibility between the old code and the new code is that the old radio class has been designed to be a container for structural programming while the new LCD code is more object oriented. This made the program inconsistent and unstable.
The radio is basically usable, now. The development will slow down in the next months if no other people take the challenge.
Conflicts: README piradio piradio.postinst radio_class.py select_daemon.sh translate_class.py
This will hopefully prevent the remote control thread from dying if the connection to MPD does not work properly.
The piface libraries are sometimes hard to debug and have some issues with dying threads that cannot be restarted. In order to fix these issues they are copied inside the source tree. They have been renamed to avoid clashes with the original libraries.
This temporary enables killing the radio application from init.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current branch is the result of my attempts to make the radio usable with my Piface Control & Display extension board.
Some limitations of the original piradio annoyed me:
• It doesn't allow autmatic configuration of the radio stations
• It does not support IR remote controls
• It deos not support to browse the directory structure of the music.
• It uses a strange design for the debian project.
Trying to solve these problems, I ended up with something that's more or less a rewrite, but supports additional features as an object oriented menu system.
At least I wanted to inform you about the project. I think some technical details could be interesting to you, too. Feel free to comment, please.
BTW. My distri is based on the MusicBox project (http://pimusicbox.com/) and uses the mopidy repositories.
Warning
As the design changed so much during the development nearly everything I don't use is probably broken.