Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a version of deploy's README #6

Merged
merged 1 commit into from
May 28, 2024
Merged

adds a version of deploy's README #6

merged 1 commit into from
May 28, 2024

Conversation

ChrisC
Copy link
Contributor

@ChrisC ChrisC commented May 28, 2024

Note that this removed the sections about locking down and provision from the original repo since these have been converted into npm commands in this project.

Note that this removed the sections about locking down and provision from the original repo since these have been converted into npm commands in this project.
Copy link
Collaborator

@outofambit outofambit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one little edit and then lgtm, thanks!

Comment on lines +100 to +101
- src: ../LICENSE.md
dest: /home/{{ domain }}/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- src: ../LICENSE.md
dest: /home/{{ domain }}/

can we remove these lines? i took them out of the sample inventory file because this template doesn't include a license and this caused the deploy workflow to error when run.

@boazsender boazsender merged commit 11df0d3 into main May 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants