Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First results #14

Merged
merged 29 commits into from
Jul 8, 2024
Merged

First results #14

merged 29 commits into from
Jul 8, 2024

Conversation

felimomo
Copy link
Collaborator

@felimomo felimomo commented Jun 19, 2024 •
edited
Loading

The main changes here are:

  • the lognormal - uniform distribution for r-devs (and making it default)
  • a full observation fn (observes full age structured population)
  • an 'enforce min' harvest fn (penalizes harvests below a certain threshold)
  • explicit checkpoint times in train.py
  • add a test function for the CautionaryRule agent

Felipe Montealegre-Mora added 29 commits June 13, 2024 19:54
hyperpars
f1f65a0
added full observe fn, and enforce-min harvest fn
06f3345
longer training, checkpoints for long training
2ce029f
notebooks
1ef7296
added lognormal noise, made it default
3f653a7
generator syntax for rand numbers, lognormal params
89d044d
added new mean-corrected r-dev function (and made it default)
d694e9f
Merge branch 'main' into first-results
a31e7e6
typo
7fa356a
clarifying comment
536dbeb
no exponential term
9506b53
need kwargs to make mean-corrected fn compatible with old version
977f16b
r_devs now lognormal + big school anomalies
15b77ca
sdr as arg
d04582f
train.py: checkpoint locations
80ca027
hf directory typo
ec71568
notebooks
ed034d5
erased old models of r-devs
8d301be
episodes notebook updated to new r-devs
72a68b9
clipping syntax
98c255f
get_r_devs back compatibility
09d565d
added nicer policy plots
1f1d69a
readme
9d8544b
added CR agent test
31a8d1f
CR test debug
24f4d54
test debug
123fb2a
test debug
12363ed
test debug
14137cf
test debug
504f8d7
@felimomo felimomo requested a review from cboettig July 1, 2024 23:06
@felimomo
Copy link
Collaborator Author

felimomo commented Jul 1, 2024

Hey, @cboettig can you take a look at this PR? I'd say the main things that happened are updating the asm_fns.get_r_devs function, and adding some agent tests for CautionaryRule.

(Will follow up with similar tests for other agents---figured that it could help guide development in any follow-up project where I would have limited time!)

@cboettig
Copy link
Member

cboettig commented Jul 6, 2024

@felimomo apologies I've been away this week, will look at this first thing next week

cboettig
cboettig approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@cboettig cboettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah fantastic work! so nice to have the notebooks here with cached results and all.

@felimomo felimomo merged commit c877881 into main Jul 8, 2024
2 checks passed
@felimomo felimomo deleted the first-results branch July 10, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cboettig cboettig cboettig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felimomo @cboettig