Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2 examples (basic use and timeouts) and support for Teensy 3.2 #96

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thomasfredericks
Copy link
Contributor

No description provided.

@amotl
Copy link
Contributor

amotl commented Feb 17, 2019

Dear @thomasfredericks,

we just pushed some amendments [1] to this popular library where we rebundled some pieces which have been loosely floating around here. While being at it, we also cherry-picked your valuable contributions and suggestions which not have been merged yet, thanks again. For more details, please follow the issue referenced above.

As we actually don't have any hardware on our workbench, we will be happy to hear about successful reports from the community running this on a real iron, actually on as much as possible things supported by the Arduino framework. Maybe you can afford some minutes to check whether the status quo works as expected if you still have a MCU and a HX711 breakout around?

We will appreciate your feedback, thanks already.

With kind regards,
Andreas.

[1] https://github.com/hiveeyes/HX711/tree/spring-cleaning

@thomasfredericks
Copy link
Contributor Author

@amotl Sorry, I cannot test this right now.

One thing I would strongly change in your documentation is to remove all references to analog pins like this one:

// AVR and friends
const int LOADCELL_DOUT_PIN = A1;
const int LOADCELL_SCK_PIN = A0;

This confuses students as they believe that 1) it is an analog input and 2) the loadcell must be connected to an analog pin. Both of there are wrong.

@amotl
Copy link
Contributor

amotl commented Feb 19, 2019

Dear @thomasfredericks,

thanks a bunch for your answer. For things like the pin definition aspect I was exactly asking for in #124 as I felt the documentation or the example sketches provided might also need some facelift here. However, we probably have to take the different boards into account.

So, you mean that having references to the A* pins is complete nonsense? Personally, I am totally clueless as I'm not a hardware guy so I am dependent on your input here whether this would hold true specifically for the Teensy boards or as a general rule for all boards.

Let's hear what @bogde has to say about this.

With kind regards,
Andreas.

P.S.: We will be happy to hear back from you if there's another chance to get the revamped library into the hands of students in the future. All of this is valuable feedback. Thanks again!

@amotl
Copy link
Contributor

amotl commented Feb 19, 2019

Dear Thomas,

while working on #125 in the aftermath of #123, we just added your wait-for-readyness-with-timeout implementation to our spring-cleaning branch by 87727e0.

By using the new wait_ready_timeout(), the corresponding HX711_timeout_example.ino originally contributed by you becomes even more compact now.

With kind regards,
Andreas.

@thomasfredericks
Copy link
Contributor Author

So, you mean that having references to the A* pins is complete nonsense?

It is not nonsense, it will work but it is just that analog pins are not required. Typically analog pins are only used when require as they are precious. You can use the same pins as the ESP and friends:

// ESP and friends
const int LOADCELL_DOUT_PIN = D2;
const int LOADCELL_SCK_PIN = D3;

@amotl
Copy link
Contributor

amotl commented Feb 20, 2019

Typically analog pins are only used when required as they are precious. You can use the [digital] pins [like you are doing with] the ESP and friends.

Based on your suggestion and after further research, we just removed the attempt to use pin definition constants at all by 83c9f51, see also #124. Thanks again!

@amotl
Copy link
Contributor

amotl commented Feb 20, 2019

Thanks @thomasfredericks, your contributions have been very valuable for the recent work on this library. As being superseded by merging #123, we might close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants