add todo for upload using gst_gl_upload

bojidartonchev · Oct 14, 2023 · 6ce9d3f · 6ce9d3f
1 parent 9e9631a
commit 6ce9d3f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/plugins/gstreamer_video_player/frame.c b/src/plugins/gstreamer_video_player/frame.c
@@ -622,7 +622,7 @@ get_plane_infos(GstBuffer *buffer, const GstVideoInfo *info, struct gbm_device *
         if (n_memories != 1) {
             ok = dup_gst_buffer_range_as_dmabuf(gbm_device, buffer, memory_index, n_memories);
             if (ok < 0) {
-                LOG_ERROR("Could not duplicate gstreamer memory as dmabuf.\n");
+                LOG_ERROR("Could not duplicate gstreamer buffer range as dmabuf.\n");
                 ok = EIO;
                 goto fail_close_fds;
             }

diff --git a/src/plugins/gstreamer_video_player/player.c b/src/plugins/gstreamer_video_player/player.c
@@ -767,6 +767,7 @@ static GstFlowReturn on_appsink_new_preroll(GstAppSink *appsink, void *userdata)
         return GST_FLOW_ERROR;
     }
 
+    /// TODO: Attempt to upload using gst_gl_upload here
     frame = frame_new(player->frame_interface, sample, player->has_gst_info ? &player->gst_info : NULL);
 
     gst_sample_unref(sample);
@@ -795,6 +796,7 @@ static GstFlowReturn on_appsink_new_sample(GstAppSink *appsink, void *userdata)
 
     player = userdata;
 
+    /// TODO: Attempt to upload using gst_gl_upload here
     sample = gst_app_sink_try_pull_sample(appsink, 0);
     if (sample == NULL) {
         LOG_ERROR("gstreamer returned a NULL sample.\n");