Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Five PRs in one: Update to Python 3, rely on PATH, rename script, fix a typo, add gerdriesselmann's fix from issue #2 #3

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

hacklschorsch
Copy link

@hacklschorsch hacklschorsch commented Nov 3, 2021

Thank you for your script!

I especially like that it comes w/o heavy dependencies and is easy to follow.

For our setup I had to change a couple of things; Please see this PR if you find anything of interest.

Merge at will or please drop me a line if you'd like me to turn this into distinct PRs.

Cheers!

@hacklschorsch hacklschorsch changed the title Four PRs in one: Update to Python 3, rely on PATH, rename script, fix a typo Five PRs in one: Update to Python 3, rely on PATH, rename script, fix a typo, add gerdriesselmann's fix from issue #2 Nov 3, 2021
@hacklschorsch
Copy link
Author

Added a fix for a metric missing from our MegaCli64 output.

@hbokh
Copy link

hbokh commented Jul 27, 2022

The initial script was not working, but this PR did! 👍🏻
Only changed the shebang into #!/usr/bin/env python3 and MegaCli64 into megacli (since that is in $PATH).

@stefangweichinger
Copy link

nice PR. Although I get no separate temperatures per slot, it seems (I can't select slots to display per disk):

# TYPE megacli_pd_temperature gauge
megacli_pd_temperature{adapter="None", enclosure="None", slot="None", type="celsius"} 21
megacli_pd_temperature{adapter="None", enclosure="None", slot="None", type="barbarians"} 69.80
megacli_pd_temperature{adapter="None", enclosure="None", slot="None", type="celsius"} 21
megacli_pd_temperature{adapter="None", enclosure="None", slot="None", type="barbarians"} 69.80
megacli_pd_temperature{adapter="None", enclosure="None", slot="None", type="celsius"} 21
megacli_pd_temperature{adapter="None", enclosure="None", slot="None", type="barbarians"} 69.80
megacli_pd_temperature{adapter="None", enclosure="None", slot="None", type="celsius"} 21
megacli_pd_temperature{adapter="None", enclosure="None", slot="None", type="barbarians"} 69.80

Any idea? I can provide raw data, if helpful.

megacli_controller{adapter="None", product_name="PRAID EP420i"} 1

@hacklschorsch
Copy link
Author

nice PR.

Thanks @stefangweichinger !

I am afraid nothing in this PR has anything to do with the issues you are seeing.
Maybe open a new issue or new PR?

We have a couple of different MegaRAID controllers, and annoyingly MegaCli64 outputs different stats depending on the HW - so this same script throws exceptions on one controller and runs fine on another.

@stefangweichinger
Copy link

@hacklschorsch I am getting lost a bit between megacli, storcli, smartctl ... basically I want to read and monitor the drive temperatures. megaclisas-status shows them for example, but so far I couldn't find a working exporter doing that.

Yes, I might create a new PR out of #3 (comment)
Thanks.

@hacklschorsch
Copy link
Author

I agree this is much harder than it should be.

@stefangweichinger
Copy link

Getting the drive-temperatures via smartmon.py now.
Controller temperature is not returned by storcli.py for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants