Skip to content

Commit

Permalink
Minor cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
philippjfr committed Mar 22, 2024
1 parent 61b9cdc commit 3f2571e
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions ipywidgets_bokeh/src/manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -194,17 +194,15 @@ export class WidgetManager extends HTMLManager {
const comm = (() => {
const key = target_name + model_id
let comm = this._comms.get(key)
if (comm != null) {
return comm
} else {
if (this.kernel.hasComm(model_id) {
if (!comm) {

Check failure on line 197 in ipywidgets_bokeh/src/manager.ts

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest, 18.x)

Unexpected nullable object value in conditional. An explicit null check is required

Check failure on line 197 in ipywidgets_bokeh/src/manager.ts

View workflow job for this annotation

GitHub Actions / test (macos-latest, 18.x)

Unexpected nullable object value in conditional. An explicit null check is required

Check failure on line 197 in ipywidgets_bokeh/src/manager.ts

View workflow job for this annotation

GitHub Actions / test (windows-latest, 18.x)

Unexpected nullable object value in conditional. An explicit null check is required
if (this.kernel.hasComm(model_id)) {
comm = (this.kernel as any)._comms.get(model_id)
} else {

Check failure on line 200 in ipywidgets_bokeh/src/manager.ts

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest, 18.x)

Expected indentation of 8 spaces but found 1 tab

Check failure on line 200 in ipywidgets_bokeh/src/manager.ts

View workflow job for this annotation

GitHub Actions / test (macos-latest, 18.x)

Expected indentation of 8 spaces but found 1 tab

Check failure on line 200 in ipywidgets_bokeh/src/manager.ts

View workflow job for this annotation

GitHub Actions / test (windows-latest, 18.x)

Expected indentation of 8 spaces but found 1 tab
comm = this.kernel.createComm(target_name, model_id)
}

Check failure on line 202 in ipywidgets_bokeh/src/manager.ts

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest, 18.x)

Expected indentation of 8 spaces but found 1 tab

Check failure on line 202 in ipywidgets_bokeh/src/manager.ts

View workflow job for this annotation

GitHub Actions / test (macos-latest, 18.x)

Expected indentation of 8 spaces but found 1 tab

Check failure on line 202 in ipywidgets_bokeh/src/manager.ts

View workflow job for this annotation

GitHub Actions / test (windows-latest, 18.x)

Expected indentation of 8 spaces but found 1 tab
this._comms.set(key, comm)
return comm
}
return comm
})()
comm.open(data, metadata, buffers)
return new shims.services.Comm(comm)
Expand Down

0 comments on commit 3f2571e

Please sign in to comment.