Skip to content

Commit

Permalink
Fix path specification passed to AC_CHECK_PROG when checking for File…
Browse files Browse the repository at this point in the history
…Check

The set of locations in which `AC_CHECK_PROG` looks for a program is
passed to the macro as a colon-separated path specification.

However, in the invocation of `AC_CHECK_PROG` for `FileCheck`, this
specification is preceded by an extra `path = `, which causes the
first location to be interpreted as `path = $CLANG_PREFIX/bin` rather
than `$CLANG_PREFIX/bin`. This causes the check to fail, even if the
file `$CLANG_PREFIX/bin/FileCheck` exists and is executable.

Removing the prefix makes the check work as expected.

Signed-off-by: Andi Drebes <[email protected]>
  • Loading branch information
andidr authored and bondhugula committed May 12, 2024
1 parent 001cb37 commit 655ca80
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ AC_ARG_WITH(clang-prefix,
AM_CONDITIONAL(EXTERNAL_CLANG, test x$external_clang = xtrue)

dnl TODO: check for FileCheck at other places.
AC_CHECK_PROG(FILECHECK,FileCheck,yes,no,path = "$CLANG_PREFIX/bin:$PATH:/usr/lib64/llvm")
AC_CHECK_PROG(FILECHECK,FileCheck,yes,no,"$CLANG_PREFIX/bin:$PATH:/usr/lib64/llvm")
AS_IF([test x"$FILECHECK" != x"yes"], [AC_MSG_ERROR([Please install LLVM FileCheck before configuring.])])

glpk="false"
Expand Down

0 comments on commit 655ca80

Please sign in to comment.