Skip to content

Conversation

boneskull
Copy link
Owner

No description provided.

@Copilot Copilot AI review requested due to automatic review settings October 20, 2025 08:11
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates test snapshots to reflect changes in error message formatting. The changes remove ANSI color escape sequences from assertion error messages, making them simpler and more readable in plain text.

Key Changes:

  • Removed ANSI color codes (\u001b[32m, \u001b[39m, etc.) from error message snapshots
  • Updated test assertions to use newer/simpler assertion syntax (e.g., 'to be empty' instead of 'to be an empty array')
  • Fixed assertion method calls that were using incorrect or outdated syntax

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/assertion-error/sync-parametric-error.test.ts.snapshot Updated snapshots removing ANSI codes; added proper error structures for previously unhandled assertions
test/assertion-error/sync-parametric-error.test.ts Changed assertion syntax to match updated API (e.g., 'to throw error satisfying', 'to be within')
test/assertion-error/sync-esoteric-error.test.ts.snapshot Removed ANSI formatting codes from error messages
test/assertion-error/sync-date-error.test.ts.snapshot Removed ANSI color codes from date comparison error messages
test/assertion-error/sync-collection-error.test.ts.snapshot Removed ANSI codes from collection assertion error messages
test/assertion-error/sync-basic-error.test.ts.snapshot Transformed UnknownAssertionError to proper AssertionError with ANSI codes removed
test/assertion-error/sync-basic-error.test.ts Updated assertion method calls to use current API syntax
test/assertion-error/async-parametric-error.test.ts.snapshot Removed ANSI color codes from async assertion error messages
test/assertion-error/assert-error.test.ts.snapshot Removed ANSI codes from both custom and Node.js assert error messages

@boneskull boneskull force-pushed the fix-broken-snapshots branch from 716656f to 8ef8370 Compare October 20, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant