Make Book entity abstract

Signed-off-by: Lasse Mammen <[email protected]>
bookboon · Jan 31, 2019 · 9ccd486 · 9ccd486
1 parent d62561e
commit 9ccd486
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/src/Entity/Book.php b/src/Entity/Book.php
@@ -6,7 +6,7 @@
 use Bookboon\Api\Client\BookboonResponse;
 use Bookboon\Api\Client\ClientInterface;
 
-class Book extends Entity
+abstract class Book extends Entity
 {
     const _OWN_TYPE = '';
 
@@ -104,7 +104,7 @@ public static function getAll(
      * @param array $objectArray
      * @return Book
      */
-    private static function objectTransformer(array $objectArray)
+    public static function objectTransformer(array $objectArray)
     {
         $className = 'Bookboon\Api\Entity\\' . ucfirst($objectArray['_type']) . 'Book';
         return new $className($objectArray);

diff --git a/src/Entity/Exam.php b/src/Entity/Exam.php
@@ -128,11 +128,10 @@ public function getTimeSeconds()
      * Return book to which the exam is related
      *
      * @return Book
-     * @throws \Bookboon\Api\Exception\EntityDataException
      */
     public function getBook()
     {
-        return new Book($this->safeGet('book', []));
+        return Book::objectTransformer($this->safeGet('book', []));
     }
 
     /**

diff --git a/tests/Entity/BookTest.php b/tests/Entity/BookTest.php
@@ -107,7 +107,7 @@ public function testHasPdf()
      */
     public function testInvalidBook()
     {
-        $book = new Book(['blah']);
+        $book = new PdfBook(['blah']);
     }
 
     public function testBookDownloadOauth()