Merge pull request #33 from bookboon/hotfix/prevent-incorrect-use

Prevent performance issues in Book::getMultiple
bookboon · Jan 31, 2019 · e9df690 · e9df690
2 parents 7d7965b + 4da169c
commit e9df690
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/Entity/Book.php b/src/Entity/Book.php
@@ -5,6 +5,7 @@
 use Bookboon\Api\Bookboon;
 use Bookboon\Api\Client\BookboonResponse;
 use Bookboon\Api\Client\ClientInterface;
+use Bookboon\Api\Exception\UsageException;
 
 class Book extends Entity
 {
@@ -57,6 +58,11 @@ public static function getMultiple(
         array $bookIds,
         bool $extendedMetadata = false
     ) : BookboonResponse {
+        if (count($bookIds) === 0) {
+            throw new UsageException('At least one id is required for bookIds');
+        }
+
+
         $variables = [
             'id' => $bookIds,
             'extendedMetadata' => $extendedMetadata ? 'true' : 'false'
@@ -79,6 +85,8 @@ public static function getMultiple(
      * @param string $type
      * @return BookboonResponse
      * @throws \Bookboon\Api\Exception\UsageException
+     *
+     * @deprecated Shouln't be used for performance reasons
      */
     public static function getAll(
         Bookboon $bookboon,