possible fix for #3372 - user export timeouts #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This definitely needs to be tested on a large DB but I believe it may fix the timeouts b.s. gets when running user exports. Instead of a gigantic single DB query with heaps of joins, we instead just do a series of simple queries and then use union() to pull them into a de-duped queryset. If I understand the results from explain() correctly, this is a massive reduction in DB work: Unique (cost=195899.15..198201.71 rows=11808 width=19220) vs Unique (cost=150.28..153.44 rows=16 width=19220)
hughrun
added
the
performance
|
I tried this with the query time test system in #3380 and it when from 0.06 to 0.003 which is a huge improvement! |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you finished?
Linters
black,pylint, andmypy, or./bw-dev formattersTests
What type of Pull Request is this?
Does this PR change settings or dependencies, or break something?
Details of breaking or configuration changes (if any of above checked)
Description
This definitely needs to be tested on a large DB but I believe it may fix the timeouts b.s. gets when running user exports.
Instead of a gigantic single DB query with heaps of joins, we instead just do a series of simple queries and then use
union()to pull them into a de-duped queryset.If I understand the results from
explain()correctly, this is a massive reduction in DB work:Unique (cost=195899.15..198201.71 rows=11808 width=19220)vs
Unique (cost=150.28..153.44 rows=16 width=19220)Documentation