-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noah Lennestad #90
Open
noahlenn
wants to merge
1
commit into
boolean-uk:main
Choose a base branch
from
noahlenn:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Noah Lennestad #90
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,8 +43,9 @@ public ArrayList<Integer> getFavouriteNumbers() { | |
TODO: 1. Create a method named getSecondNumber that returns a whole number. It must return the | ||
second number contained in the list that is returned from getFavouriteNumbers | ||
*/ | ||
|
||
|
||
public int getSecondNumber() { | ||
return getFavouriteNumbers().get(1); | ||
} | ||
|
||
/* | ||
TODO: 2. Create a method named multiply that accepts two parameters in this order: | ||
|
@@ -55,6 +56,14 @@ public ArrayList<Integer> getFavouriteNumbers() { | |
Use the ArrayList's replaceAll method to iterate through the ArrayList and replace each value with its double | ||
https://www.programiz.com/java-programming/library/arraylist/replaceall | ||
*/ | ||
public ArrayList<Integer> multiply(ArrayList<Integer> list, int number) { | ||
for(int i = 0; i < list.size(); i++) { | ||
int newNumber = list.get(i) * number; | ||
list.set(i, newNumber); | ||
} | ||
return list; | ||
} | ||
|
||
|
||
|
||
|
||
|
@@ -63,6 +72,9 @@ public ArrayList<Integer> getFavouriteNumbers() { | |
- A list of strings | ||
The method must return a boolean that indicates whether the provided list is empty or not | ||
*/ | ||
public boolean isEmpty(ArrayList<String> list) { | ||
return list.isEmpty(); | ||
} | ||
|
||
|
||
|
||
|
@@ -72,7 +84,11 @@ public ArrayList<Integer> getFavouriteNumbers() { | |
- A string | ||
The method must add the second parameter into the list provided and then return the list | ||
*/ | ||
public ArrayList<String> addIngredient(ArrayList<String> list, String text){ | ||
list.add(text); | ||
|
||
return list; | ||
} | ||
|
||
|
||
/* | ||
|
@@ -81,6 +97,16 @@ public ArrayList<Integer> getFavouriteNumbers() { | |
- A string | ||
The method must remove the second parameter from the list and then return the list | ||
*/ | ||
public ArrayList<String> removeIngredient(ArrayList<String> list, String text){ | ||
for(int i = 0; i < list.size(); i++){ | ||
if(list.get(i).equals(text)){ | ||
list.remove(i); | ||
|
||
} | ||
|
||
} | ||
return list; | ||
} | ||
|
||
|
||
|
||
|
@@ -90,6 +116,18 @@ public ArrayList<Integer> getFavouriteNumbers() { | |
- A string | ||
The method must return a boolean that indicates whether the second parameter exists in the provided list | ||
*/ | ||
public boolean containsIngredient(ArrayList<String> list, String text){ | ||
for(int i = 0; i < list.size(); i++){ | ||
if(list.get(i).equals(text)){ | ||
return true; | ||
|
||
} | ||
|
||
} | ||
return false; | ||
|
||
|
||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Again could be simplified by making use of pre-existing methods. eg:
|
||
|
||
|
||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be simplified, eg: