Mattias Hedbom #137
Open
Mattias Hedbom #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 10, 2025 13:03
…lings/ bagels etc.
…lings/ bagels etc. Also changed the return-value of showAllFillingsWithCosts()
…est for the same method
…so identified an error in my domain model that I corrected.
…tWithDiscounts();
…hus I created two new classes and deleted the "extension-code" from the core exercise
added 11 commits
January 14, 2025 11:02
…fulfill this requirement
…ne used for the extension (1 & 2). Also updated the domain model with the receipt class
totalCostWithDiscounts() costWithDiscounts() Updated the totalCostWithDiscounts() from the first extension so it accepts a HashMap instead. Created new tests for this new method
…hod, therefore I needed to slightly change the domain model, the test and lastly the method
…tly altered the domain model
ninja-aruna
reviewed
Jan 15, 2025
| String allFillingsWithPrices = ""; | ||
| for(Item anItem : this.itemsOnMenu){ | ||
| if(anItem.getTypeOfItem().equals("Filling")){ | ||
| allFillingsWithPrices += anItem.getName() + ", " + anItem.getPrice() + "$\n"; |
There was a problem hiding this comment.
Use stringbuilder in place of concatenating strings in a loop, as strings are immutable, so a new string will be created at each iteration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.