-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Extension to Work With Latest Solidus #42
Open
cpfergus1
wants to merge
10
commits into
boomerdigital:master
Choose a base branch
from
cpfergus1:cpfergus1/update-extension-to-latest
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update Extension to Work With Latest Solidus #42
cpfergus1
wants to merge
10
commits into
boomerdigital:master
from
cpfergus1:cpfergus1/update-extension-to-latest
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result of running `bundle exec solidus extension .`
cpfergus1
force-pushed
the
cpfergus1/update-extension-to-latest
branch
2 times, most recently
from
May 5, 2023 16:00
154c901
to
e9e47ce
Compare
cpfergus1
force-pushed
the
cpfergus1/update-extension-to-latest
branch
from
May 5, 2023 16:08
e9e47ce
to
7872c5c
Compare
cpfergus1
force-pushed
the
cpfergus1/update-extension-to-latest
branch
2 times, most recently
from
May 5, 2023 17:07
c6be1bc
to
f8ddf18
Compare
Fixes MySQL error
cpfergus1
force-pushed
the
cpfergus1/update-extension-to-latest
branch
from
May 5, 2023 17:11
f8ddf18
to
4a5a46d
Compare
@acreilly, |
Change in Solidus 2.6 Replace button_link_to with either button_to or link_to #2601 (jhawthorn)
kennyadsl
reviewed
Jun 8, 2023
spec.executables = files.grep(%r{^exe/}) { |f| File.basename(f) } | ||
spec.require_paths = ["lib"] | ||
|
||
spec.add_dependency 'solidus_core', ['>= 2.0.0', '< 4'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be <5
now that Solidus 4 is out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update utilizes Solidus dev tools to bump this extension to work with the latest version of Solidus. Minor changes to deprecated code were made to ensure functionality