Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E03 T01] 장르, Sort정보(난이도, 만족도, 거리순) 버튼 Cell UI를 작업한다. #22

Merged
merged 4 commits into from
Nov 3, 2021
Merged

[E03 T01] 장르, Sort정보(난이도, 만족도, 거리순) 버튼 Cell UI를 작업한다. #22

merged 4 commits into from
Nov 3, 2021

Conversation

shinhee-rebecca
Copy link
Collaborator

@shinhee-rebecca shinhee-rebecca commented Nov 3, 2021 •
edited
Loading

issue number : #02

작업 사항

  • Tagable 프로토콜 생성 및 적용
  • ColorPallete에 색상 추가
  • TagButton 구현

체크리스트

  • Merge 하는 브랜치가 올바른가?
  • 코딩컨벤션을 준수하는가?
  • PR과 관련없는 변경사항이 없는가?
  • 내 코드에 대한 자기 검토가 되었는가?
  • 변경사항이 효과적이거나 동작이 작동한다는 것을 보증하는 테스트를 추가하였는가?
  • 새로운 테스트와 기존의 테스트가 변경사항에 대해 만족하는가?

close #2

poisonF2
poisonF2 reviewed Nov 3, 2021
View reviewed changes
Copy link
Collaborator

@poisonF2 poisonF2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

색 추가 및 버튼 구현 확인했습니다.

Escaper/Escaper/Presentation/RoomList/Views/TagButton.swift Outdated Show resolved Hide resolved
@shinhee-rebecca shinhee-rebecca merged commit 3570476 into boostcampwm-2021:develop Nov 3, 2021
@shinhee-rebecca shinhee-rebecca deleted the feat/roomList/tagScrollView branch November 3, 2021 13:43
@wansook0316 wansook0316 changed the title Feat/room list/tag scroll view [E03 T01] 장르, Sort정보(난이도, 만족도, 거리순) 버튼 Cell UI를 작업한다. Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poisonF2 poisonF2 poisonF2 left review comments

@jeffoio jeffoio Awaiting requested review from jeffoio

Assignees

@wansook0316 wansook0316

@shinhee-rebecca shinhee-rebecca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[E03 T01] 장르, Sort정보(난이도, 만족도, 거리순) 버튼 Cell UI를 작업한다.
3 participants
@shinhee-rebecca @poisonF2 @wansook0316