Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

프로필 해시태그 편집 시 기존 해시태그 표시 #372

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

bumssooooo
Copy link
Member

PR Type

  • 기능 추가 🔨
  • 버그 수정 🐞
  • 리팩토링 🚧
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트 ⚙️
  • 기타 사소한 수정 🎸
  • 테스트 🔍

Related Issue(작업 내용)

참고 사항

추후 User 내 Hashtag 관련 프로퍼티를 String -> Hashtag로 리팩토링하는게 좋을 것 같아 이슈를 생성해두었습니다.

Screenshots(Optional)

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2022-12-07.at.14.48.55.mp4

@bumssooooo bumssooooo added feat 💡 새로운 기능 추가 범수 S005 SP 4️⃣ labels Dec 7, 2022
@bumssooooo bumssooooo self-assigned this Dec 7, 2022
Copy link
Member

@sominn9 sominn9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다. 코디네이터 리팩토링할 때 빼먹었던 부분을 잘 채워주셨네요 👍 👍

Copy link
Collaborator

@Yuhun-Lee Yuhun-Lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나머지는 Career, Category인데 Language만 s 붙어있던거 놓치고 있엇네요.
수고하셨습니다. 👍

@bumssooooo bumssooooo merged commit 02f211a into develop Dec 8, 2022
@sominn9 sominn9 deleted the fix/profile-selected-hashtag branch December 8, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 💡 새로운 기능 추가 SP 4️⃣ 범수 S005
Projects
None yet
Development

Successfully merging this pull request may close these issues.

프로필 해시태그 편집 시 기본 선택 인자 전달
3 participants