식당 마커 클릭 시 식당정보 미리보기 구현 #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+82
to
+84
| const { updateMap } = useMapStore((state) => state); | ||
| const { meetLocation } = useMeetLocationStore((state) => state); | ||
| const { updateSelectedRestaurantData } = useSelectedRestaurantDataStore((state) => state); |
There was a problem hiding this comment.
궁금한게 Map 을 전역 상태로 하나 더 생성하셨더라구요. 그러면 컴포넌트에 굳이 mapRef를 따로 생성하는게 의미가 있는지 궁금합니다.
There was a problem hiding this comment.
말씀하신대로 불필요해서 수정해야 할 부분입니다. 일단 기능 구현이 목적이었기 때문에 useNaverMaps훅 내부에 있는 로직을 MainMap 안에 다시 옮기는 작업을 하지 않았습니다. 😓
YuriKwon
reviewed
Dec 13, 2022
client/src/pages/MainPage/index.tsx
Outdated
Comment on lines
223
to
258
| <MapControlBox> | ||
| <button | ||
| type="button" | ||
| onClick={() => { | ||
| if (!map || !meetLocation) { | ||
| return; | ||
| } | ||
|
|
||
| map.setCenter(meetLocation); | ||
| }} | ||
| > | ||
| <PointCircleIcon /> | ||
| </button> | ||
| <button | ||
| type="button" | ||
| onClick={async () => { | ||
| const socket = socketRef.current; | ||
|
|
||
| if (!(socket instanceof Socket)) { | ||
| return; | ||
| } | ||
|
|
||
| const location = await getCurrentLocation(); | ||
| socket.emit('changeMyLocation', { userLat: location.lat, userLng: location.lng }); | ||
| updateUserLocation(location); | ||
|
|
||
| if (!map) { | ||
| return; | ||
| } | ||
|
|
||
| map.setCenter(location); | ||
| }} | ||
| > | ||
| <GpsIcon /> | ||
| </button> | ||
| </MapControlBox> |
|
훨씬 깔끔하네요!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
링크(관련 이슈)
개요
식당 마커를 클릭하면 하단에 미리보기 모달이 표시됩니다.
내용
일단 기능 구현에 집중했기 때문에 놓친 부분이 많을 수 있습니다.
리뷰하면서도 고쳐나가고, 추후에도 리팩토링이 필요합니다.
비고
restaurant_preview.mp4
리뷰어한테 할 말
로컬에서 실행시켜보시고 잘 작동하는지 확인해주세요!