CoreData에서 Page 데이터 읽어오기 및 보여주기 (멀티미디어 포함 X) #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Kyxxn
approved these changes
Nov 29, 2024
Comment on lines
4
to
+5
| public struct BookCoverDTO { | ||
| let identifier: UUID | ||
| let id: UUID |
There was a problem hiding this comment.
Identifiable을 안쓰는데 id로 바꾸신 이유가 있나용 ??
There was a problem hiding this comment.
다른 곳 들과의 통일성을 위해서 바꿨습니다 ! Entity와 DTO, CoreDataModel 각각의 attributes 이름이 같아야 헷갈리지 않을 것이라고 생각하여 바꿔줬습니다!
Comment on lines
14
to
25
| public func create(data: BookCoverDTO) async -> Result<Void, MHDataError> { | ||
| let context = coreDataStorage.persistentContainer.viewContext | ||
| do { | ||
| try await context.perform { | ||
| guard let entity = NSEntityDescription.entity(forEntityName: "BookCoverEntity", in: context) else { | ||
| throw MHDataError.noSuchEntity(key: "BookCoverEntity") | ||
| } | ||
| let bookCover = NSManagedObject(entity: entity, insertInto: context) | ||
| bookCover.setValue(data.identifier, forKey: "identifier") | ||
| bookCover.setValue(data.id, forKey: "id") | ||
| bookCover.setValue(data.title, forKey: "title") | ||
| bookCover.setValue(data.category, forKey: "category") | ||
| bookCover.setValue(data.color, forKey: "color") |
There was a problem hiding this comment.
코어데이터 CRUD 에 대한 메소드가 do-catch부터 entity 꺼내는 로직 등등 겹치는게 많아서
perform 처리하는 메소드를 지난 PR에서 만들어뒀습니다 !
이걸로 수정하는 건 어떨까요 ??
There was a problem hiding this comment.
모두 수정했습니다 .ᐟ.ᐟ
추가로 perform 메소드는 CoreDataStorage 객체를 가지고 있는 모든 곳에서 공통적으로 사용되는 메서드라 판단하여 CoreDataStorage의 internal 메서드로 빼주어 추가적인 보일러 플레이트 코드를 방지하도록 코드 수정했습니당 !
iceHood
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
⏰ 작업 시간
Swift6 이슈로.. 화면이 되는지 확인하는데 시간을 거의 다쓴..
📝 작업 내용
PageViewController에 띄운다.BookUseCase,BookRepositorySendable 채택📸 스크린샷
테스트용으로 CoreData에 저장한 Book
📒 리뷰 노트