BookCover 이미지 연결 #127
Merged
BookCover 이미지 연결 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- EditPhotoViewModel 삭제
Closed
Kyxxn
approved these changes
Dec 3, 2024
| @@ -23,18 +27,29 @@ final class CustomAlbumViewController: UIViewController { | |||
| private let input = PassthroughSubject<CustomAlbumViewModel.Input, Never>() | |||
| private var cancellables = Set<AnyCancellable>() | |||
| private let mediaType: PHAssetMediaType | |||
| private let mode: Mode | |||
| private let completionHandler: (_ imageData: Data, _ creationDate: Date?, _ caption: String?) -> Void | |||
There was a problem hiding this comment.
단순 궁금증인데,
보통 핸들러는 _ 로 명시적 파라미터 입력을 안 받나용 ?
There was a problem hiding this comment.
그런가봐용.. 저두 저기에 특정 파라미터 명을 넣고싶었는데 컴파일러가 에러를 띄우더라구요..??
iceHood
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
⏰ 작업 시간
📝 작업 내용
📸 스크린샷
📒 리뷰 노트
기존의 MHBook의 경우 AutoLayout의 Width, Height가 상수로 되어있어, 북 커버 수정뷰에서 보면 사진이 훨씬 작아보이는 이슈가 있었습니다. 따라서 상수보단 Leading과 Trailing을 설정해주는 방식으로 코드를 수정해주었습니다 !