Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditPage에서 이미지 추가하는 기능 구현 #129

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

k2645
Copy link
Collaborator

@k2645 k2645 commented Dec 3, 2024

#️⃣ 연관된 이슈


⏰ 작업 시간

예상 시간 실제 걸린 시간
1 1

📝 작업 내용

  • EditPage에서 이미지 업로드

📸 스크린샷

이미지 추가 및 확인

ScreenRecording_12-03-2024.20-01-03_1.MP4

@k2645 k2645 added ✨ Feature 기능 관련 작업 👷‍♂️ Refactor 코드 개선, 가독성 개선, 주석 labels Dec 3, 2024
@k2645 k2645 added this to the 0.5 milestone Dec 3, 2024
@k2645 k2645 self-assigned this Dec 3, 2024
@k2645 k2645 linked an issue Dec 3, 2024 that may be closed by this pull request
Copy link
Collaborator

@Kyxxn Kyxxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 ~~
이미지 컷!

Comment on lines -1 to 4
import UIKit
import MHFoundation
import MHCore
import UIKit
import Combine
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

편-안

Comment on lines +220 to +231
let albumViewModel = CustomAlbumViewModel()
let customAlbumViewController = CustomAlbumViewController(
viewModel: albumViewModel,
mediaType: .image,
mode: .editPage
) { imageData, creationDate, caption in
let attributes: [String: any Sendable] = [
Constant.photoCreationDate: creationDate?.toString(),
Constant.photoCaption: caption
]
self?.input.send(.didAddMediaWithData(type: .image, attributes: attributes, data: imageData))
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

미리 설정해줘야할 게 있으면 226~229번줄 처럼 attributes를 넣는 거군요,
동영상은 암것도 없어도 되겠죵..?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵넵 mediaType.video로 설정해주면 됩니당 .ᐟ.ᐟ 나머지는 default값을 넣어놔서 괜찮아용 !

@k2645 k2645 merged commit 17af1b1 into develop Dec 3, 2024
2 checks passed
@k2645 k2645 deleted the feature/upload-image-edit-book branch December 3, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 관련 작업 👷‍♂️ Refactor 코드 개선, 가독성 개선, 주석
Projects
None yet
Development

Successfully merging this pull request may close these issues.

편집 화면에서 이미지 업로드
2 participants