코드 가독성 증가 (개발의 파인 다이닝 급인듯) & 카테고리 예외처리 & 기록소 이름 예외처리 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Kyxxn
requested review from
k2645,
yuncheol-AHN and
iceHood
and removed request for
k2645 and
yuncheol-AHN
k2645
approved these changes
Dec 4, 2024
| @@ -6,7 +6,7 @@ import Photos | |||
| // TODO: - 에러 처리 필요 | |||
| final class CreateBookCoverViewModel: ViewModelType { | |||
| enum Input { | |||
| case viewDidAppear | |||
| case setBookColor | |||
There was a problem hiding this comment.
P3: 해당 input은 북 컬러를 셋팅한다기보단 BookCover를 처음에 생성하고 첫 셋팅을 총괄하는 input이라 네이밍을 SetBookCover 정도로 하는게 좋을 것 같긴합니당 !
iceHood
approved these changes
Dec 4, 2024
yuncheol-AHN
approved these changes
Dec 4, 2024
Comment on lines
+120
to
+122
| if type == .audio { | ||
| try await deleteTemporaryMediaUsecase.execute(media: description) | ||
| } |
|
개발의 파인다이닝이라... 의도가 궁금하네요. 😉 |
|
@gen-com |
|
아니요 할 게 많아서 도망다니고 있어요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
⏰ 작업 시간
📝 작업 내용
📸 스크린샷